Elgato_dark/podman-desktop
1
0
Fork 0
mirror of https://github.com/podman-desktop/podman-desktop synced 2026-05-24 10:18:53 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

chore: support different parent/child types in tables

Browse source 
A previous PR added support for having child items in tables, but the type
of the parent and child objects is the same.

For the Containers page, the parents are always ContainerGroupInfoUI and
the children are always ContainerInfoUI. This change just adds an optional
second type (identically to how we did rendering types in Column) so that
you can declare the different types naturally as:
  `ContainerGroupInfoUI, ContainerInfoUI`
instead of having to do:
  `ContainerGroupInfoUI | ContainerInfoUI`
and deal with typing issues in the client code.

Part of #4843.

Signed-off-by: Tim deBoer <git@tdeboer.ca>
This commit is contained in:
Tim deBoer 2024-06-07 08:20:55 -04:00
parent ed956877b6
commit 26c41833cd
1 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
packages/ui/src/lib/table/table.ts
View file

@ -96,7 +96,7 @@ export class Column<Type, RenderType = Type> {
/**
* Options to be used when creating a Row.
*/
export interface RowInformation<Type> {
export interface RowInformation<Type, ChildType> {
/**
* Returns true if a row can be selected, and false otherwise.
*/
@ -110,12 +110,12 @@ export interface RowInformation<Type> {
/**
* Returns an array of child objects of a given row.
*/
readonly children?: (object: Type) => Type[];
readonly children?: (object: Type) => ChildType[];
}
/**
* A table row.
*/
export class Row<Type> {
constructor(readonly info: RowInformation<Type>) {}
export class Row<Type, ChildType = Type> {
constructor(readonly info: RowInformation<Type, ChildType>) {}
}