feat: enable split groups renderer path (#669)

This commit is contained in:
Brennan Benson 2026-04-15 13:12:54 -07:00 committed by GitHub
parent f5b716a760
commit e4cdb29a01
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 16 additions and 8 deletions

View file

@ -0,0 +1,14 @@
# Split Groups PR 6: Enable Split Groups
This branch turns split groups on after the earlier model, lifecycle, restore,
and renderer-ownership branches are in place.
Scope:
- remove the temporary rollout gate from `Terminal.tsx`
- make the split-group ownership path the active renderer path
- keep only the small bootstrap fallback for cases where no layout exists yet
What Is Actually Hooked Up In This PR:
- split groups are live
- `Terminal.tsx` always resolves through the split-group path when layout/group state exists
- the temporary gate introduced in the dark-launch PR is removed instead of left behind as dead config

View file

@ -1,6 +1,6 @@
{
"name": "orca",
"version": "1.1.33-rc.3",
"version": "1.1.33-rc.4",
"description": "An Electron application with React and TypeScript",
"homepage": "https://github.com/stablyai/orca",
"author": "stablyai",

View file

@ -31,10 +31,6 @@ import { shouldAutoCreateInitialTerminal } from './terminal/initial-terminal'
import CodexRestartChip from './CodexRestartChip'
const EditorPanel = lazy(() => import('./editor/EditorPanel'))
// Why: keep the split-group renderer path dark until dedicated Playwright
// coverage lands. This branch keeps the implementation and correctness fixes,
// but the user-visible rollout stays on the legacy workspace path by default.
const ENABLE_SPLIT_GROUPS = false
function Terminal(): React.JSX.Element | null {
const activeWorktreeId = useAppStore((s) => s.activeWorktreeId)
@ -123,9 +119,7 @@ function Terminal(): React.JSX.Element | null {
[activeGroupIdByWorktree, groupsByWorktree, layoutByWorktree]
)
const effectiveActiveLayout = activeWorktreeId
? ENABLE_SPLIT_GROUPS
? getEffectiveLayoutForWorktree(activeWorktreeId)
: undefined
? getEffectiveLayoutForWorktree(activeWorktreeId)
: undefined
const activeWorktree = activeWorktreeId
? (allWorktrees.find((worktree) => worktree.id === activeWorktreeId) ?? null)