Elgato_dark/orca
1
0
Fork 0
mirror of https://github.com/stablyai/orca synced 2026-04-21 14:17:16 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

fix: update tests for Safari/Firefox browser detection and ZDOTDIR (#788)

Browse source
This commit is contained in:
Jinwoo Hong 2026-04-18 00:31:39 -04:00 committed by GitHub
parent 68e3a00ddf
commit be7ee2fc38
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 13 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
src/main/browser/browser-cookie-import.test.ts
View file

@ -217,14 +217,17 @@ describe('detectInstalledBrowsers', () => {
expect(browser).toHaveProperty('family')
expect(browser).toHaveProperty('label')
expect(browser).toHaveProperty('cookiesPath')
expect(browser).toHaveProperty('keychainService')
expect(browser).toHaveProperty('keychainAccount')
// keychainService/keychainAccount are only present for Chromium-based browsers
if (['chrome', 'edge', 'arc', 'chromium'].includes(browser.family)) {
expect(browser).toHaveProperty('keychainService')
expect(browser).toHaveProperty('keychainAccount')
}
}
})
it('each detected browser has a valid family', () => {
const browsers = detectInstalledBrowsers()
const validFamilies = ['chrome', 'edge', 'arc', 'chromium']
const validFamilies = ['chrome', 'edge', 'arc', 'chromium', 'firefox', 'safari']
for (const browser of browsers) {
expect(validFamilies).toContain(browser.family)
}

7
src/main/ipc/pty.test.ts
View file

@ -493,12 +493,14 @@ describe('registerPtyHandlers', () => {
it('spawns a plain POSIX login shell and queues startup commands for the live session', () => {
const originalPlatform = process.platform
const originalShell = process.env.SHELL
const originalZdotdir = process.env.ZDOTDIR
Object.defineProperty(process, 'platform', {
configurable: true,
value: 'darwin'
})
process.env.SHELL = '/bin/zsh'
delete process.env.ZDOTDIR
try {
const [shell, args, options] = spawnAndGetCall({ cwd: '/tmp', command: 'printf "hello"' })
@ -516,6 +518,11 @@ describe('registerPtyHandlers', () => {
} else {
process.env.SHELL = originalShell
}
if (originalZdotdir === undefined) {
delete process.env.ZDOTDIR
} else {
process.env.ZDOTDIR = originalZdotdir
}
}
})