Elgato_dark/openclaw-nerve
1
0
Fork 0
mirror of https://github.com/daggerhashimoto/openclaw-nerve synced 2026-04-21 10:37:17 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

fix(markdown): polish review follow-ups

Browse source
This commit is contained in:
daggerhashimoto 2026-04-06 22:17:17 +02:00
parent 2333a0ec17
commit eecb8171c1
2 changed files with 54 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

59
src/features/markdown/MarkdownRenderer.test.tsx
View file

@ -80,7 +80,22 @@ describe('MarkdownRenderer', () => {
);
fireEvent.click(screen.getByRole('link', { name: '/workspace/src/App.tsx' }));
expect(onOpenWorkspacePath).toHaveBeenCalledWith('/workspace/src/App.tsx');
expect(onOpenWorkspacePath).toHaveBeenCalledWith('/workspace/src/App.tsx', undefined);
});
it('passes current document context to inline path references too', () => {
const onOpenWorkspacePath = vi.fn();
render(
<MarkdownRenderer
content="Open /workspace/src/App.tsx now"
onOpenWorkspacePath={onOpenWorkspacePath}
pathLinkPrefixes={['/workspace/']}
currentDocumentPath="notes/index.md"
/>,
);
fireEvent.click(screen.getByRole('link', { name: '/workspace/src/App.tsx' }));
expect(onOpenWorkspacePath).toHaveBeenCalledWith('/workspace/src/App.tsx', 'notes/index.md');
});
it('logs and swallows rejected inline workspace path opens', async () => {
@ -115,16 +130,18 @@ describe('MarkdownRenderer', () => {
expect(screen.queryByRole('link', { name: '/workspace/src/App.tsx' })).toBeNull();
});
it('opens workspace links in-app when a handler is provided', () => {
it('opens workspace links in-app when a handler is provided', async () => {
const onOpenWorkspacePath = vi.fn();
render(<MarkdownRenderer content="[notes](docs/todo.md)" onOpenWorkspacePath={onOpenWorkspacePath} />);
fireEvent.click(screen.getByRole('link', { name: 'notes' }));
expect(onOpenWorkspacePath).toHaveBeenCalledWith('docs/todo.md', undefined);
await waitFor(() => {
expect(onOpenWorkspacePath).toHaveBeenCalledWith('docs/todo.md', undefined);
});
});
it('passes the current document path for markdown-document-relative links', () => {
it('passes the current document path for markdown-document-relative links', async () => {
const onOpenWorkspacePath = vi.fn();
render(
<MarkdownRenderer
@ -136,10 +153,12 @@ describe('MarkdownRenderer', () => {
fireEvent.click(screen.getByRole('link', { name: 'advanced' }));
expect(onOpenWorkspacePath).toHaveBeenCalledWith('../advanced.md', 'docs/guide/index.md');
await waitFor(() => {
expect(onOpenWorkspacePath).toHaveBeenCalledWith('../advanced.md', 'docs/guide/index.md');
});
});
it('preserves leading-slash workspace links for markdown documents', () => {
it('preserves leading-slash workspace links for markdown documents', async () => {
const onOpenWorkspacePath = vi.fn();
render(
<MarkdownRenderer
@ -151,7 +170,9 @@ describe('MarkdownRenderer', () => {
fireEvent.click(screen.getByRole('link', { name: 'todo' }));
expect(onOpenWorkspacePath).toHaveBeenCalledWith('/docs/todo.md', 'notes/index.md');
await waitFor(() => {
expect(onOpenWorkspacePath).toHaveBeenCalledWith('/docs/todo.md', 'notes/index.md');
});
});
it('splits fragments from workspace link paths before opening files', async () => {
@ -176,7 +197,7 @@ describe('MarkdownRenderer', () => {
replaceState.mockRestore();
});
it('does not split encoded hash characters in workspace link paths', () => {
it('does not split encoded hash characters in workspace link paths', async () => {
const onOpenWorkspacePath = vi.fn();
render(
<MarkdownRenderer
@ -187,7 +208,9 @@ describe('MarkdownRenderer', () => {
fireEvent.click(screen.getByRole('link', { name: 'guide' }));
expect(onOpenWorkspacePath).toHaveBeenCalledWith('foo#bar.md', undefined);
await waitFor(() => {
expect(onOpenWorkspacePath).toHaveBeenCalledWith('foo#bar.md', undefined);
});
});
it('adds stable ids to headings for same-document anchor navigation', () => {
@ -268,6 +291,24 @@ describe('MarkdownRenderer', () => {
consoleError.mockRestore();
});
it('logs and swallows synchronous throws from markdown workspace link opens', async () => {
const error = new Error('boom');
const onOpenWorkspacePath = vi.fn(() => {
throw error;
});
const consoleError = vi.spyOn(console, 'error').mockImplementation(() => {});
render(<MarkdownRenderer content="[notes](docs/todo.md)" onOpenWorkspacePath={onOpenWorkspacePath} />);
fireEvent.click(screen.getByRole('link', { name: 'notes' }));
await waitFor(() => {
expect(consoleError).toHaveBeenCalledWith('Failed to open workspace path link:', error);
});
consoleError.mockRestore();
});
it('keeps external links as normal browser links when a handler is provided', () => {
const onOpenWorkspacePath = vi.fn();
render(<MarkdownRenderer content="[example](https://example.com)" onOpenWorkspacePath={onOpenWorkspacePath} />);

7
src/features/markdown/MarkdownRenderer.tsx
View file

@ -234,9 +234,9 @@ export function MarkdownRenderer({
searchQuery,
pathLinkPrefixes,
onOpenWorkspacePath: onOpenWorkspacePath
? (path: string) => onOpenWorkspacePath(path)
? (path: string) => onOpenWorkspacePath(path, currentDocumentPath)
: undefined,
}), [searchQuery, pathLinkPrefixes, onOpenWorkspacePath]);
}), [searchQuery, pathLinkPrefixes, onOpenWorkspacePath, currentDocumentPath]);
const scrollToAnchorId = useCallback((anchorId: string, behavior: ScrollBehavior = 'smooth') => {
const root = containerRef.current;
@ -382,7 +382,8 @@ export function MarkdownRenderer({
className={mergedClassName}
onClick={(event) => {
event.preventDefault();
Promise.resolve(onOpenWorkspacePath(normalizedTarget, currentDocumentPath))
Promise.resolve()
.then(() => onOpenWorkspacePath(normalizedTarget, currentDocumentPath))
.then(() => {
if (fragment) {
updateLocationHash(fragment);