From 54881e189dc91a0e59e61a0e8de097028d1f01a9 Mon Sep 17 00:00:00 2001 From: Matsu Date: Fri, 10 Apr 2026 12:58:59 +0300 Subject: [PATCH] chore: Update create-pr skill and PR template (no-changelog) (#28302) --- .../create-community-node-lint-rule/SKILL.md | 1 - .claude/plugins/n8n/skills/create-pr/SKILL.md | 29 +++++++++---------- .../plugins/n8n/skills/reproduce-bug/SKILL.md | 1 - .github/pull_request_template.md | 2 +- 4 files changed, 14 insertions(+), 19 deletions(-) diff --git a/.claude/plugins/n8n/skills/create-community-node-lint-rule/SKILL.md b/.claude/plugins/n8n/skills/create-community-node-lint-rule/SKILL.md index 41c6e2cafb6..e7a2f511fd6 100644 --- a/.claude/plugins/n8n/skills/create-community-node-lint-rule/SKILL.md +++ b/.claude/plugins/n8n/skills/create-community-node-lint-rule/SKILL.md @@ -4,7 +4,6 @@ description: >- Use when adding a lint rule, creating a community node lint, or working on eslint-plugin-community-nodes. Guides rule implementation, tests, docs, and plugin registration. -user_invocable: true --- # Create Community Node Lint Rule diff --git a/.claude/plugins/n8n/skills/create-pr/SKILL.md b/.claude/plugins/n8n/skills/create-pr/SKILL.md index 6054f402957..57ddceb4854 100644 --- a/.claude/plugins/n8n/skills/create-pr/SKILL.md +++ b/.claude/plugins/n8n/skills/create-pr/SKILL.md @@ -72,24 +72,17 @@ Creates GitHub PRs with titles that pass n8n's `check-pr-title` CI validation. git push -u origin HEAD ``` -6. **Create PR** using gh CLI with the template from `.github/pull_request_template.md`: +6. **Create PR** using gh CLI. Read `.github/pull_request_template.md` as the + body structure, then populate each section with actual content before + creating the PR: + - **Summary**: describe what the PR does and how to test it + - **Related tickets**: add the Linear ticket URL (`https://linear.app/n8n/issue/[TICKET-ID]`) and any GitHub issue links + - **Checklist**: keep as-is from the template + - Add a "🤖 PR Summary generated by AI" at the end of the body + ```bash gh pr create --draft --title "(): " --body "$(cat <<'EOF' - ## Summary - - - - ## Related Linear tickets, Github issues, and Community forum posts - - - - - ## Review / Merge checklist - - - [ ] PR title and summary are descriptive. ([conventions](../blob/master/.github/pull_request_title_conventions.md)) - - [ ] [Docs updated](https://github.com/n8n-io/n8n-docs) or follow-up ticket created. - - [ ] Tests included. - - [ ] PR Labeled with `release/backport` (if the PR is an urgent fix that needs to be backported) + EOF )" ``` @@ -111,6 +104,7 @@ Based on `.github/pull_request_template.md`: ### Checklist All items should be addressed before merging: +- The human author of the PR has checked the "I have seen this code, I have run this code, and I take responsibility for this code." checkbox - PR title follows conventions - Docs updated or follow-up ticket created - Tests included (bugs need regression tests, features need coverage) @@ -191,5 +185,8 @@ Describe **what the code does**, not what threat it prevents. | Linear ref | URL with slug (leaks title) | URL without slug or ticket ID only | | Test name | `'should prevent SQL injection'` | `'should sanitize query parameters'` | + **Before pushing a security fix, verify:** no branch name, commit, PR title, PR body, Linear URL, test name, or code comment hints at the vulnerability. + +**When in doubt, check the Linear issue for possible extra precautions** diff --git a/.claude/plugins/n8n/skills/reproduce-bug/SKILL.md b/.claude/plugins/n8n/skills/reproduce-bug/SKILL.md index d4cedd3c059..6e387f14495 100644 --- a/.claude/plugins/n8n/skills/reproduce-bug/SKILL.md +++ b/.claude/plugins/n8n/skills/reproduce-bug/SKILL.md @@ -1,6 +1,5 @@ --- description: Reproduce a bug from a Linear ticket with a failing test. Expects the full ticket context (title, description, comments) to be provided as input. -user_invocable: true --- # Bug Reproduction Framework diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index 28aa4ac96e7..82b85452bee 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -10,7 +10,7 @@ Photos and videos are recommended.