Elgato_dark/lobehub
1
0
Fork 0
mirror of https://github.com/lobehub/lobehub synced 2026-04-21 17:47:27 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 86

♻️ refactor: narrow storage_block error typing in upload action
Some checks are pending
E2E CI / Check Duplicate Run (push) Waiting to run
Details
E2E CI / Test Web App (push) Blocked by required conditions
Details
Test CI / Check Duplicate Run (push) Waiting to run
Details
Test CI / Test Packages (push) Blocked by required conditions
Details
Test CI / Test App (shard 1/3) (push) Blocked by required conditions
Details
Test CI / Test App (shard 2/3) (push) Blocked by required conditions
Details
Test CI / Test App (shard 3/3) (push) Blocked by required conditions
Details
Test CI / Merge and Upload App Coverage (push) Blocked by required conditions
Details
Test CI / Test Desktop App (push) Blocked by required conditions
Details
Test CI / Test Database (push) Blocked by required conditions
Details

Browse source 
Replace `(error as any)?.message` with `instanceof Error` guard and tighten
the errorKeyMap type via `satisfies Record<StorageBlockReason, string>` so
new StorageBlockReason variants are caught at compile time.
This commit is contained in:
YuTengjing 2026-04-21 11:37:03 +08:00
parent 5400c07bfa
commit d1c2c60242
No known key found for this signature in database
1 changed files with 16 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

20
src/store/file/slices/upload/action.ts
View file

@ -183,24 +183,36 @@ export class FileUploadActionImpl {
return { ...data, dimensions, filename: file.name };
} catch (error) {
const errorMessage = (error as any)?.message ?? '';
const errorMessage = error instanceof Error ? error.message : '';
// Handle structured storage block reasons (storage_block:<reason>)
if (errorMessage.startsWith('storage_block:')) {
const reason = errorMessage.replace('storage_block:', '');
onStatusUpdate?.({ id: statusId, type: 'removeFile' });
const errorKeyMap: Record<string, string> = {
// Keep this union in sync with cloud `StorageBlockReason` in
// src/server/services/storageOverage/index.ts (cloud repo).
type StorageBlockReason =
| 'monthly_cap_reached'
| 'no_payment_method'
| 'overage_not_enabled'
| 'subscription_past_due'
| 'subscription_unpaid'
| 'upgrade_required';
const errorKeyMap = {
monthly_cap_reached: 'upload.storageBlock.monthlyCapReached',
no_payment_method: 'upload.storageBlock.noPaymentMethod',
overage_not_enabled: 'upload.storageBlock.overageNotEnabled',
subscription_past_due: 'upload.storageBlock.subscriptionPastDue',
subscription_unpaid: 'upload.storageBlock.subscriptionUnpaid',
upgrade_required: 'upload.storageBlock.upgradeRequired',
};
} as const satisfies Record<StorageBlockReason, string>;
const key = (errorKeyMap as Record<string, string>)[reason];
notification.error({
description: t(errorKeyMap[reason] ?? 'upload.storageLimitExceeded', { ns: 'error' }),
description: t(key ?? 'upload.storageLimitExceeded', { ns: 'error' }),
message: t('upload.uploadFailed', { ns: 'error' }),
});
return;