Elgato_dark/hyperdx
1
0
Fork 0
mirror of https://github.com/hyperdxio/hyperdx synced 2026-04-21 13:37:15 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

fix: remove play button and time picker from markdown tab (#1141)

Browse source 
This PR fixes: HDX-1641

The Linear issue only mentions:

> The Run button on the Markdown form doesn't do anything

However, in **Charts Explorer → Markdown**, the time picker also wasn’t working. I’ve removed it as well.

<img width="2681" height="2048" alt="image" src="https://github.com/user-attachments/assets/6f6b7fc5-544f-43e2-ab9d-05894f83e8d6" />
This commit is contained in:
Elizabet Oliveira 2025-09-04 18:31:00 +01:00 committed by GitHub
parent 042e359547
commit fb66126e06
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 17 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
.changeset/fair-eagles-explode.md Normal file
View file

@ -0,0 +1,5 @@
---
"@hyperdx/app": patch
---
fix: remove play button and time picker from markdown tab

21
packages/app/src/components/DBEditTimeChartForm.tsx
View file

@ -849,7 +849,8 @@ export default function EditTimeChartForm({
)}
</Flex>
<Flex gap="sm" my="sm" align="center" justify="end">
{setDisplayedTimeInputValue != null &&
{activeTab !== 'markdown' &&
setDisplayedTimeInputValue != null &&
displayedTimeInputValue != null &&
onTimeRangeSearch != null && (
<TimePicker
@ -866,14 +867,16 @@ export default function EditTimeChartForm({
{activeTab === 'time' && (
<GranularityPickerControlled control={control} name="granularity" />
)}
<Button
variant="outline"
type="submit"
color="green"
onClick={onSubmit}
>
<i className="bi bi-play"></i>
</Button>
{activeTab !== 'markdown' && (
<Button
variant="outline"
type="submit"
color="green"
onClick={onSubmit}
>
<i className="bi bi-play"></i>
</Button>
)}
</Flex>
</Flex>
{!queryReady && activeTab !== 'markdown' ? (