Elgato_dark/hyperdx
1
0
Fork 0
mirror of https://github.com/hyperdxio/hyperdx synced 2026-04-21 13:37:15 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

fix: Fix intermittently-missing SQL autocomplete suggestions (#1980)

Browse source
This commit is contained in:
Drew Davis 2026-03-24 13:45:34 -04:00 committed by GitHub
parent cdc29d5a88
commit dd313f7754
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 10 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
.changeset/tasty-owls-heal.md Normal file
View file

@ -0,0 +1,5 @@
---
"@hyperdx/app": patch
---
fix: Fix intermittently-missing SQL autocomplete suggestions

8
packages/app/src/components/SQLEditor/SQLInlineEditor.tsx
View file

@ -144,9 +144,10 @@ export default function SQLInlineEditor({
const compartmentRef = useRef<Compartment>(new Compartment());
const hasNonEmptyValue = value.trim().length > 0;
const updateAutocompleteColumns = useCallback(
(viewRef: EditorView) => {
const currentText = viewRef.state.doc.toString();
const identifiers = [
...(filteredFields?.map(column => {
if (column.path.length > 1) {
@ -171,15 +172,16 @@ export default function SQLInlineEditor({
});
viewRef.dispatch({
effects: compartmentRef.current.reconfigure(
currentText.length > 0 ? auto : queryHistoryList,
hasNonEmptyValue ? auto : queryHistoryList,
),
});
},
[
filteredFields,
additionalSuggestions,
createHistoryList,
disableKeywordAutocomplete,
createHistoryList,
hasNonEmptyValue,
],
);