Elgato_dark/hyperdx
1
0
Fork 0
mirror of https://github.com/hyperdxio/hyperdx synced 2026-04-21 13:37:15 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

Metric Chart Alerts: increase duration for at least 2 data points (#147)

Browse source
This commit is contained in:
Justin George 2023-12-19 11:14:42 -08:00 committed by GitHub
parent 29d1e03071
commit bb4f90d26b
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 16 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
.changeset/shaggy-peas-shop.md Normal file
View file

@ -0,0 +1,5 @@
---
'@hyperdx/api': patch
---
Adjust time window for sum-rate alerts

2
packages/api/src/clickhouse/index.ts
View file

@ -689,7 +689,7 @@ const getMetricsTagsCached = async (teamId: string) => {
}
};
const isRateAggFn = (aggFn: AggFn) => {
export const isRateAggFn = (aggFn: AggFn) => {
return (
aggFn === AggFn.SumRate ||
aggFn === AggFn.AvgRate ||

11
packages/api/src/tasks/checkAlerts.ts
View file

@ -421,12 +421,21 @@ export const processAlert = async (now: Date, alert: AlertDocument) => {
series.field
) {
targetDashboard = dashboard;
const startTimeMs = fns.getTime(checkStartTime);
let startTimeMs = fns.getTime(checkStartTime);
const endTimeMs = fns.getTime(checkEndTime);
const [metricName, rawMetricDataType] = series.field.split(' - ');
const metricDataType = z
.nativeEnum(clickhouse.MetricsDataType)
.parse(rawMetricDataType);
if (
metricDataType === clickhouse.MetricsDataType.Sum &&
clickhouse.isRateAggFn(series.aggFn)
) {
// adjust the time so that we have enough data points to calculate a rate
startTimeMs = fns
.subMinutes(startTimeMs, windowSizeInMins)
.getTime();
}
checksData = await clickhouse.getMetricsChart({
aggFn: series.aggFn,
dataType: metricDataType,