Elgato_dark/hyperdx
1
0
Fork 0
mirror of https://github.com/hyperdxio/hyperdx synced 2026-04-21 13:37:15 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

fix: restrict heatmap data source picker to trace sources only

Browse source 
Heatmap charts require trace data (duration expression) to work properly.
Non-trace sources would error out with no guidance. Instead of adding
complex error messaging, filter the source dropdown to only show trace
sources when heatmap display type is selected.
This commit is contained in:
Alex Fedotyev 2026-04-14 19:01:25 -07:00
parent 59b2476956
commit a587ca25f7
2 changed files with 12 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
packages/app/src/components/DBEditTimeChartForm/ChartEditorControls.tsx
View file

@ -99,6 +99,11 @@ export function ChartEditorControls({
control={control}
name="source"
data-testid="source-selector"
allowedSourceKinds={
displayType === DisplayType.Heatmap
? [SourceKind.Trace]
: undefined
}
sourceSchemaPreview={
<SourceSchemaPreview source={tableSource} variant="text" />
}

19
packages/app/src/components/DBEditTimeChartForm/EditTimeChartForm.tsx
View file

@ -417,14 +417,11 @@ export default function EditTimeChartForm({
}
if (displayType === DisplayType.Heatmap && Array.isArray(select)) {
const traceSource =
const defaultValue =
tableSource?.kind === SourceKind.Trace &&
tableSource.durationExpression
? tableSource
: undefined;
const defaultValue = traceSource
? getDurationMsExpression(traceSource)
: (select[0]?.valueExpression ?? '');
? getDurationMsExpression(tableSource)
: (select[0]?.valueExpression ?? '');
const heatmapSeries: SavedChartConfigWithSelectArray['select'] = [
{
aggFn: 'count',
@ -436,12 +433,10 @@ export default function EditTimeChartForm({
setValue('select', heatmapSeries);
setValue('series', heatmapSeries);
setValue('series.0.countExpression' as any, 'count()');
if (traceSource) {
setValue('numberFormat', {
output: 'duration' as any,
factor: 0.001,
});
}
setValue('numberFormat', {
output: 'duration' as any,
factor: 0.001,
});
}
// Don't auto-submit when config type changes, to avoid clearing form state (like source)