From 9a72b85ea8ba178beaae65e01f39959ced82d337 Mon Sep 17 00:00:00 2001 From: Warren <5959690+wrn14897@users.noreply.github.com> Date: Mon, 20 Nov 2023 02:03:20 -0800 Subject: [PATCH] fix: getLogBatchGroupedByBody missing return bug (#115) --- .changeset/bright-hornets-drop.md | 6 ++++++ packages/api/src/clickhouse/index.ts | 3 +++ packages/api/src/routers/api/logs.ts | 3 --- 3 files changed, 9 insertions(+), 3 deletions(-) create mode 100644 .changeset/bright-hornets-drop.md diff --git a/.changeset/bright-hornets-drop.md b/.changeset/bright-hornets-drop.md new file mode 100644 index 00000000..d1e22af0 --- /dev/null +++ b/.changeset/bright-hornets-drop.md @@ -0,0 +1,6 @@ +--- +'@hyperdx/api': patch +'@hyperdx/app': patch +--- + +fix: getLogBatchGroupedByBody missing return bug (regression) diff --git a/packages/api/src/clickhouse/index.ts b/packages/api/src/clickhouse/index.ts index 940eb5d0..63bc3343 100644 --- a/packages/api/src/clickhouse/index.ts +++ b/packages/api/src/clickhouse/index.ts @@ -1694,6 +1694,9 @@ export const getLogBatchGroupedByBody = async ({ span.end(); }, ); + + // @ts-ignore + return result; }; export const getLogBatch = async ({ diff --git a/packages/api/src/routers/api/logs.ts b/packages/api/src/routers/api/logs.ts index 62340bfd..4a2506cc 100644 --- a/packages/api/src/routers/api/logs.ts +++ b/packages/api/src/routers/api/logs.ts @@ -109,12 +109,10 @@ router.get('/patterns', isUserAuthenticated, async (req, res, next) => { teamId: teamId.toString(), }); - // @ts-expect-error if (logs.data.length === 0) { return res.json({ data: [] }); } - // @ts-expect-error // use the 1st id as the representative id const lines = logs.data.map(log => [log.ids[0], log.body]); // TODO: separate patterns by service @@ -136,7 +134,6 @@ router.get('/patterns', isUserAuthenticated, async (req, res, next) => { trends: Record; } > = {}; - // @ts-expect-error for (const log of logs.data) { const patternId = logsPatternsData.result[log.ids[0]]; if (patternId) {