Elgato_dark/hyperdx
1
0
Fork 0
mirror of https://github.com/hyperdxio/hyperdx synced 2026-04-21 13:37:15 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

fix(app): negative duration in search (#28)

Browse source 
Co-authored-by: Warren <5959690+wrn14897@users.noreply.github.com>
Co-authored-by: Mike Shi <mike@deploysentinel.com>
This commit is contained in:
Mark Omarov 2023-09-25 04:12:22 +09:00 committed by GitHub
parent 911c02a443
commit 8b103f3f57
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 25 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
.changeset/shiny-needles-cross.md Normal file
View file

@ -0,0 +1,10 @@
---
'@hyperdx/app': patch
---
fix(app): negative duration in search
Duration column in the search interface displayed negative numbers when only a
timestamp was present. This fix changes the behavior to display "N/A" for such
cases, clarifying that the duration is not applicable rather than displaying a
misleading negative number.

16
packages/app/src/LogTable.tsx
View file

@ -13,6 +13,7 @@ import cx from 'classnames';
import { Button, Modal } from 'react-bootstrap';
import stripAnsi from 'strip-ansi';
import { CSVLink } from 'react-csv';
import curry from 'lodash/curry';
import Checkbox from './Checkbox';
import FieldMultiSelect from './FieldMultiSelect';
@ -23,6 +24,19 @@ import { usePrevious, useWindowSize } from './utils';
import { useSearchEventStream } from './search';
import { useHotkeys } from 'react-hotkeys-hook';
type Row = Record<string, any> & { duration: number };
type AccessorFn = (row: Row, column: string) => any;
const ACCESSOR_MAP: Record<string, AccessorFn> = {
duration: row => (row.duration >= 0 ? row.duration : 'N/A'),
default: (row, column) => row[column],
};
function retrieveColumnValue(column: string, row: Row): any {
const accessor = ACCESSOR_MAP[column] ?? ACCESSOR_MAP.default;
return accessor(row, column);
}
function DownloadCSVButton({
config: { where, dateRange },
extraFields,
@ -351,7 +365,7 @@ export const RawLogTable = memo(
size: isSmallScreen ? 70 : 100,
},
...(displayedColumns.map(column => ({
accessorFn: row => row[column], // Columns can contain '.' and will not work with accessorKey
accessorFn: curry(retrieveColumnValue)(column), // Columns can contain '.' and will not work with accessorKey
header: column,
cell: info => (
<span