diff --git a/.changeset/calm-foxes-fly.md b/.changeset/calm-foxes-fly.md new file mode 100644 index 00000000..994fe3b0 --- /dev/null +++ b/.changeset/calm-foxes-fly.md @@ -0,0 +1,5 @@ +--- +"@hyperdx/app": patch +--- + +fix: Show sidebar favorites empty state when none are starred yet diff --git a/packages/app/src/components/AppNav/AppNav.tsx b/packages/app/src/components/AppNav/AppNav.tsx index 35dc7dbd..e3bfdb0a 100644 --- a/packages/app/src/components/AppNav/AppNav.tsx +++ b/packages/app/src/components/AppNav/AppNav.tsx @@ -400,10 +400,20 @@ export default function AppNav({ fixed = false }: { fixed?: boolean }) { onToggle={() => setIsSavedSearchExpanded(!isSavedSearchExpanded)} /> - {!isCollapsed && !!favoritedSavedSearches.length && ( + {!isCollapsed && (
- {favoritedSavedSearches.map(renderSavedSearchLink)} + {favoritedSavedSearches.length > 0 ? ( + favoritedSavedSearches.map(renderSavedSearchLink) + ) : favorites != null && savedSearches != null ? ( + + No favorites. Star on{' '} + + Saved Searches + + . + + ) : null}
)} @@ -430,10 +440,24 @@ export default function AppNav({ fixed = false }: { fixed?: boolean }) { onToggle={() => setIsDashboardsExpanded(!isDashboardsExpanded)} /> - {!isCollapsed && !!favoritedDashboards.length && ( + {!isCollapsed && (
- {favoritedDashboards.map(renderDashboardLink)} + {favoritedDashboards.length > 0 ? ( + favoritedDashboards.map(renderDashboardLink) + ) : favorites != null && dashboards != null ? ( + + No favorites. Star on{' '} + + Dashboards + + . + + ) : null}
)}