Elgato_dark/hyperdx
1
0
Fork 0
mirror of https://github.com/hyperdxio/hyperdx synced 2026-04-21 13:37:15 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

feat: Save last source as default source on search page load (#790)

Browse source 
fixes HDX-1680
This commit is contained in:
Mike Shi 2025-05-05 18:31:12 +02:00 committed by GitHub
parent 5254a6f555
commit 6dc6989fdc
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 30 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
.changeset/happy-hornets-join.md Normal file
View file

@ -0,0 +1,5 @@
---
"@hyperdx/app": patch
---
feat: Automatically use last used source when loading search page

28
packages/app/src/DBSearchPage.tsx
View file

@ -92,7 +92,7 @@ import {
useSources,
} from '@/source';
import { parseTimeQuery, useNewTimeQuery } from '@/timeQuery';
import { QUERY_LOCAL_STORAGE, usePrevious } from '@/utils';
import { QUERY_LOCAL_STORAGE, useLocalStorage, usePrevious } from '@/utils';
import { SQLPreview } from './components/ChartSQLPreview';
import PatternTable from './components/PatternTable';
@ -472,6 +472,10 @@ function DBSearchPage() {
);
const { data: sources } = useSources();
const [lastSelectedSourceId, setLastSelectedSourceId] = useLocalStorage(
'hdx-last-selected-source-id',
'',
);
const { data: searchedSource } = useSource({
id: searchedConfig.source,
});
@ -514,7 +518,13 @@ function DBSearchPage() {
select: searchedConfig.select || '',
where: searchedConfig.where || '',
whereLanguage: searchedConfig.whereLanguage ?? 'lucene',
source: searchedConfig.source ?? sources?.[0]?.id ?? '',
source:
searchedConfig.source ??
(lastSelectedSourceId &&
sources?.some(s => s.id === lastSelectedSourceId)
? lastSelectedSourceId
: sources?.[0]?.id) ??
'',
filters: searchedConfig.filters ?? [],
orderBy: searchedConfig.orderBy ?? '',
},
@ -623,6 +633,8 @@ function DBSearchPage() {
setSearchedConfig,
savedSearchId,
inputSource,
lastSelectedSourceId,
sources,
]);
const [_queryErrors, setQueryErrors] = useState<{
@ -676,6 +688,9 @@ function DBSearchPage() {
s => s.id === data.source,
);
if (newInputSourceObj != null) {
// Save the selected source ID to localStorage
setLastSelectedSourceId(newInputSourceObj.id);
setValue(
'select',
newInputSourceObj?.defaultTableSelectExpression ?? '',
@ -692,7 +707,14 @@ function DBSearchPage() {
}
});
return () => unsubscribe();
}, [watch, inputSourceObj, setValue, inputSourceObjs, searchFilters]);
}, [
watch,
inputSourceObj,
setValue,
inputSourceObjs,
searchFilters,
setLastSelectedSourceId,
]);
const onTableScroll = useCallback(
(scrollTop: number) => {