Elgato_dark/hyperdx
1
0
Fork 0
mirror of https://github.com/hyperdxio/hyperdx synced 2026-04-21 13:37:15 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

fix bug where reading value when server is offline could throw client error (#1154)

Browse source
This commit is contained in:
Brandon Pereira 2025-09-10 15:07:57 -06:00 committed by GitHub
parent c48f418114
commit 5c88c46375
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 30 additions and 16 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
.changeset/short-peas-sin.md Normal file
View file

@ -0,0 +1,5 @@
---
"@hyperdx/app": patch
---
fix bug where reading value when server is offline could throw client error

41
packages/app/src/components/DBTimeChart.tsx
View file

@ -75,22 +75,31 @@ function DBTimeChartComponent({
const { graphResults, timestampColumn, groupKeys, lineNames, lineColors } =
useMemo(() => {
return data != null && isSuccess
? formatResponseForTimeChart({
res: data,
dateRange,
granularity,
generateEmptyBuckets: fillNulls !== false,
source,
})
: {
graphResults: [],
timestampColumn: undefined,
groupKeys: [],
lineNames: [],
lineColors: [],
};
}, [data, dateRange, granularity, isSuccess, fillNulls]);
const defaultResponse = {
graphResults: [],
timestampColumn: undefined,
groupKeys: [],
lineNames: [],
lineColors: [],
};
if (data == null || !isSuccess) {
return defaultResponse;
}
try {
return formatResponseForTimeChart({
res: data,
dateRange,
granularity,
generateEmptyBuckets: fillNulls !== false,
source,
});
} catch (e) {
console.error(e);
return defaultResponse;
}
}, [data, dateRange, granularity, isSuccess, fillNulls, source]);
// To enable backward compatibility, allow non-controlled usage of displayType
const [displayTypeLocal, setDisplayTypeLocal] = useState(displayTypeProp);