fix prop warnings (#1366)

Very minor PR which fixes 2 HTML structure issues (div under p, button under button).

Before: 
<img width="968" height="146" alt="Screenshot 2025-11-13 at 6 58 22 PM" src="https://github.com/user-attachments/assets/ca16ea04-d308-47ec-a3f0-74a8c639dd4b" />

After:
Non prop errors (on search page at least)
This commit is contained in:
Brandon Pereira 2025-11-14 09:59:55 -05:00 committed by GitHub
parent 94a669d3ca
commit 3fb5ef7083
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
4 changed files with 10 additions and 2 deletions

View file

@ -0,0 +1,5 @@
---
"@hyperdx/app": patch
---
Small fix for html structure nesting issues

View file

@ -51,8 +51,10 @@ export const DBRowTableIconButton: React.FC<DBRowTableIconButtonProps> = ({
>
<UnstyledButton
onClick={handleClick}
component="div"
className={baseClasses}
tabIndex={tabIndex}
role="button"
>
{isActive ? <IconCheck size={iconSize} /> : children}
</UnstyledButton>

View file

@ -327,6 +327,7 @@ export default function SQLInlineEditor({
style={{
whiteSpace: 'nowrap',
}}
component="div"
>
<Tooltip label={tooltipText} disabled={!tooltipText}>
<Flex align="center" gap={2}>

View file

@ -110,7 +110,7 @@ test.describe('Multiline Input', { tag: '@search' }, () => {
if (config.mode === 'SQL') {
const scopedContainer = formSelector ? container : page;
const whereLabel = scopedContainer.locator(
`p.mantine-Text-root:has-text("${whereText}")`,
`div.mantine-Text-root:has-text("${whereText}")`,
);
await expect(whereLabel).toBeVisible();
}
@ -122,7 +122,7 @@ test.describe('Multiline Input', { tag: '@search' }, () => {
? (() => {
const scopedContainer = formSelector ? container : page;
const whereContainer = scopedContainer.locator(
`div:has(p.mantine-Text-root:has-text("${whereText}"))`,
`div:has(div.mantine-Text-root:has-text("${whereText}"))`,
);
return whereContainer.locator('.cm-editor').first();
})()