Elgato_dark/hyperdx
1
0
Fork 0
mirror of https://github.com/hyperdxio/hyperdx synced 2026-04-21 13:37:15 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

fix: display "temporary dashboard" banner until dashboard is created (#1554)

Browse source
This commit is contained in:
Karl Power 2026-01-05 18:31:12 +01:00 committed by GitHub
parent 6a6709bb3b
commit 3b71fecb79
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
5 changed files with 35 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
.changeset/real-drinks-tap.md Normal file
View file

@ -0,0 +1,5 @@
---
"@hyperdx/app": patch
---
fix: display "temporary dashboard" banner until dashboard is created

5
packages/app/src/DBDashboardPage.tsx
View file

@ -563,7 +563,6 @@ function DBDashboardPage({ presetConfig }: { presetConfig?: Dashboard }) {
setDashboard,
dashboardHash,
isLocalDashboard,
isLocalDashboardEmpty,
isFetching: isFetchingDashboard,
isSetting: isSavingDashboard,
} = useDashboard({
@ -917,8 +916,8 @@ function DBDashboardPage({ presetConfig }: { presetConfig?: Dashboard }) {
);
}}
/>
{IS_LOCAL_MODE === false && isLocalDashboard && isLocalDashboardEmpty && (
<Paper my="lg" p="md">
{IS_LOCAL_MODE === false && isLocalDashboard && (
<Paper my="lg" p="md" data-testid="temporary-dashboard-banner">
<Flex justify="space-between" align="center">
<Text size="sm">
This is a temporary dashboard and can not be saved.

1
packages/app/src/dashboard.ts
View file

@ -166,7 +166,6 @@ export function useDashboard({
setDashboard,
dashboardHash,
isLocalDashboard,
isLocalDashboardEmpty: localDashboard == null,
isFetching: isFetchingRemoteDashboard,
isSetting,
};

20
packages/app/tests/e2e/features/dashboard.spec.ts
View file

@ -9,6 +9,26 @@ test.describe('Dashboard', { tag: ['@dashboard'] }, () => {
await dashboardPage.goto();
});
test(
'should display the "temporary dashboard" banner until the dashboard is created',
{ tag: '@full-stack' },
async () => {
await test.step('Verify that banner is initially displayed', async () => {
await expect(dashboardPage.temporaryDashboardBanner).toBeVisible();
});
await test.step('Add a tile, verify that banner is still displayed', async () => {
await dashboardPage.addTileWithConfig('Test tile');
await expect(dashboardPage.temporaryDashboardBanner).toBeVisible();
});
await test.step('Create the dashboard, verify the banner is no longer displayed', async () => {
await dashboardPage.createNewDashboard();
await expect(dashboardPage.temporaryDashboardBanner).toBeHidden();
});
},
);
test(
'should persist dashboard across page reloads',
{ tag: '@full-stack' },

8
packages/app/tests/e2e/page-objects/DashboardPage.ts
View file

@ -19,6 +19,7 @@ export class DashboardPage {
private readonly searchInput: Locator;
private readonly searchSubmitButton: Locator;
private readonly liveButton: Locator;
private readonly tempDashboardBanner: Locator;
constructor(page: Page) {
this.page = page;
@ -36,6 +37,9 @@ export class DashboardPage {
this.liveButton = page.locator('button:has-text("Live")');
this.dashboardNameHeading = page.getByRole('heading', { level: 3 });
this.granularityPicker = page.getByTestId('granularity-picker');
this.tempDashboardBanner = page.locator(
'[data-testid="temporary-dashboard-banner"]',
);
}
/**
@ -243,4 +247,8 @@ export class DashboardPage {
get filterSubmitButton() {
return this.searchSubmitButton;
}
get temporaryDashboardBanner() {
return this.tempDashboardBanner;
}
}