Elgato_dark/gitui
1
0
Fork 0
mirror of https://github.com/gitui-org/gitui synced 2026-05-24 09:28:21 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Merge branch 'fix-some-clippy-workarounds'

Browse source
This commit is contained in:
extrawurst 2022-08-20 14:44:12 +02:00
commit 79f1be0983
3 changed files with 0 additions and 19 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
asyncgit/src/sync/commits_info.rs
View file

@ -27,8 +27,6 @@ impl CommitId {
} }
} }
//TODO: remove once clippy fixed: https://github.com/rust-lang/rust-clippy/issues/6983
#[allow(clippy::wrong_self_convention)]
impl ToString for CommitId { impl ToString for CommitId {
fn to_string(&self) -> String { fn to_string(&self) -> String {
self.0.to_string() self.0.to_string()

14
asyncgit/src/sync/cred.rs
View file

@ -171,8 +171,6 @@ mod tests {
let repo_path: &RepoPath = let repo_path: &RepoPath =
&root.as_os_str().to_str().unwrap().into(); &root.as_os_str().to_str().unwrap().into();
//TODO:
// env::set_current_dir(repo_path).unwrap();
repo.remote(DEFAULT_REMOTE_NAME, "http://user@github.com") repo.remote(DEFAULT_REMOTE_NAME, "http://user@github.com")
.unwrap(); .unwrap();
@ -187,8 +185,6 @@ mod tests {
let repo_path: &RepoPath = let repo_path: &RepoPath =
&root.as_os_str().to_str().unwrap().into(); &root.as_os_str().to_str().unwrap().into();
//TODO:
// env::set_current_dir(repo_path).unwrap();
repo.remote(DEFAULT_REMOTE_NAME, "git@github.com:user/repo") repo.remote(DEFAULT_REMOTE_NAME, "git@github.com:user/repo")
.unwrap(); .unwrap();
@ -224,9 +220,6 @@ mod tests {
let repo_path: &RepoPath = let repo_path: &RepoPath =
&root.as_os_str().to_str().unwrap().into(); &root.as_os_str().to_str().unwrap().into();
//TODO:
// env::set_current_dir(repo_path).unwrap();
need_username_password(repo_path).unwrap(); need_username_password(repo_path).unwrap();
} }
@ -238,8 +231,6 @@ mod tests {
let repo_path: &RepoPath = let repo_path: &RepoPath =
&root.as_os_str().to_str().unwrap().into(); &root.as_os_str().to_str().unwrap().into();
//TODO:
// env::set_current_dir(repo_path).unwrap();
repo.remote( repo.remote(
DEFAULT_REMOTE_NAME, DEFAULT_REMOTE_NAME,
"http://user:pass@github.com", "http://user:pass@github.com",
@ -263,8 +254,6 @@ mod tests {
let repo_path: &RepoPath = let repo_path: &RepoPath =
&root.as_os_str().to_str().unwrap().into(); &root.as_os_str().to_str().unwrap().into();
//TODO:
// env::set_current_dir(repo_path).unwrap();
repo.remote(DEFAULT_REMOTE_NAME, "http://user@github.com") repo.remote(DEFAULT_REMOTE_NAME, "http://user@github.com")
.unwrap(); .unwrap();
@ -284,9 +273,6 @@ mod tests {
let repo_path: &RepoPath = let repo_path: &RepoPath =
&root.as_os_str().to_str().unwrap().into(); &root.as_os_str().to_str().unwrap().into();
//TODO: not needed anymore?
// env::set_current_dir(repo_path).unwrap();
extract_username_password(repo_path).unwrap(); extract_username_password(repo_path).unwrap();
} }
} }

3
src/components/mod.rs
View file

@ -245,9 +245,6 @@ impl From<bool> for EventState {
/// base component trait /// base component trait
pub trait Component { pub trait Component {
/// ///
//TODO: remove once workaround for clippy bug:
//<https://github.com/rust-lang/rust-clippy/issues/8366>
#[allow(clippy::ptr_arg)]
fn commands( fn commands(
&self, &self,
out: &mut Vec<CommandInfo>, out: &mut Vec<CommandInfo>,