From 614040b854bebe0f7d249b66c1bd1d0f02e278fb Mon Sep 17 00:00:00 2001
From: Stephan Dilly <dilly.stephan@gmail.com>
Date: Sat, 22 Jan 2022 18:50:51 +0100
Subject: [PATCH] add note

---
 asyncgit/src/sync/cred.rs | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/asyncgit/src/sync/cred.rs b/asyncgit/src/sync/cred.rs
index da5cb10f..57d375ee 100644
--- a/asyncgit/src/sync/cred.rs
+++ b/asyncgit/src/sync/cred.rs
@@ -55,6 +55,10 @@ pub fn extract_username_password(
 		.to_owned();
 	let mut helper = CredentialHelper::new(&url);
 
+	//TODO: look at Cred::credential_helper,
+	//if the username is in the url we need to set it here,
+	//I dont think `config` will pick it up
+
 	if let Ok(config) = Config::open_default() {
 		helper.config(&config);
 	}