From 4f2e20ea1b5d5d7c0527e35c9c86544681b17ecc Mon Sep 17 00:00:00 2001 From: Stephan Dilly Date: Tue, 18 Aug 2020 21:48:59 +0200 Subject: [PATCH] changelog update --- CHANGELOG.md | 1 + asyncgit/src/sync/hooks.rs | 8 +++++++- 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 9a4ba989..a5f27e0b 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -14,6 +14,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 ### Fixed - selection error in stashlist when deleting last element ([#223](https://github.com/extrawurst/gitui/issues/223)) +- git hooks broke ci build on windows [[@dr-BEat](https://github.com/dr-BEat)] ([#235](https://github.com/extrawurst/gitui/issues/235)) ## [0.9.1] - 2020-07-30 diff --git a/asyncgit/src/sync/hooks.rs b/asyncgit/src/sync/hooks.rs index 271e93d3..50f2ed6e 100644 --- a/asyncgit/src/sync/hooks.rs +++ b/asyncgit/src/sync/hooks.rs @@ -105,7 +105,13 @@ fn run_hook( let output = Command::new("bash") .args(bash_args) .current_dir(path) - .env("DUMMYENV", "FixPathHandlingOnWindows") // This call forces Command to handle the Path environment correctly on windows, the specific env set here does not matter + // This call forces Command to handle the Path environment correctly on windows, + // the specific env set here does not matter + // see https://github.com/rust-lang/rust/issues/37519 + .env( + "DUMMY_ENV_TO_FIX_WINDOWS_CMD_RUNS", + "FixPathHandlingOnWindows", + ) .output(); let output = output.expect("general hook error");