Elgato_dark/gemini-cli
1
0
Fork 0
mirror of https://github.com/google-gemini/gemini-cli synced 2026-04-21 13:37:17 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 19

refactor(core): use standard PlanErrorMessages constant for path access errors

Browse source 
Addresses review feedback by restoring the idiomatic PlanErrorMessages.PATH_ACCESS_DENIED constant inside resolveAndValidatePlanPath instead of a raw 'Security violation' string. This allowed for removing redundant catch-and-translate logic in exit-plan-mode.ts.
This commit is contained in:
Mahima Shanware 2026-04-17 21:20:04 +00:00
parent d3f624b165
commit 59cc70762c
3 changed files with 2 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
packages/core/src/tools/exit-plan-mode.test.ts
View file

@ -504,7 +504,7 @@ Ask the user for specific feedback on how to improve the plan.`,
});
expect(result).toBe(
`Access denied: plan path (${path.join(mockPlansDir, 'malicious.md')}) must be within the designated plans directory (${mockPlansDir}).`,
`Access denied: plan path (malicious.md) must be within the designated plans directory (${mockPlansDir}).`,
);
});

6
packages/core/src/tools/exit-plan-mode.ts
View file

@ -69,12 +69,6 @@ export class ExitPlanModeTool extends BaseDeclarativeTool<
this.config.getProjectRoot(),
);
} catch (e) {
if (e instanceof Error && e.message.startsWith('Security violation')) {
return `Access denied: plan path (${path.join(
this.config.storage.getPlansDir(),
params.plan_filename,
)}) must be within the designated plans directory (${this.config.storage.getPlansDir()}).`;
}
return e instanceof Error ? e.message : String(e);
}

2
packages/core/src/utils/planUtils.ts
View file

@ -67,7 +67,7 @@ export function resolveAndValidatePlanPath(
if (!isSubpath(realPlansDir, realPath)) {
throw new Error(
`Security violation: plan path (${trimmedPath}) must be within the designated plans directory (${plansDir}).`,
PlanErrorMessages.PATH_ACCESS_DENIED(trimmedPath, plansDir),
);
}