<!-- Add the related story/sub-task/bug number, like Resolves #123, or remove if NA --> **Related issue:** Resolves #33110 **Related issue:** Resolves #33109 # Details This PR implements the new "cancel setup if any software fails on macos" flag, including both backend and frontend logic. Half of the file changes are updating test expectations / auto-generated schema. # Checklist for submitter If some of the following don't apply, delete the relevant line. - [X] Changes file added for user-visible changes in `changes/`, `orbit/changes/` or `ee/fleetd-chrome/changes`. See [Changes files](https://github.com/fleetdm/fleet/blob/main/docs/Contributing/guides/committing-changes.md#changes-files) for more information. - [X] Input data is properly validated, `SELECT *` is avoided, SQL injection is prevented (using placeholders for values in statements) ## Testing - [X] Added/updated automated tests - [X] QA'd all new/changed functionality manually ## New Fleet configuration settings - [ ] Verified that the setting is exported via `fleetctl generate-gitops` `macos_setup` is still excluded from generate-girtops - [X] Verified the setting is documented in a separate PR to [the GitOps documentation](https://github.com/fleetdm/fleet/blob/main/docs/Configuration/yaml-files.md#L485) Documented [here](https://github.com/fleetdm/fleet/pull/33016/files) - [X] Verified that the setting is cleared on the server if it is not supplied in a YAML file (or that it is documented as being optional) - [X] Verified that any relevant UI is disabled when GitOps mode is enabled <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - New Features - Added a macOS setup option: “Cancel setup if software install fails.” - Configure at global or team level; team settings override global. - Toggle available in Setup Experience > Install software > Advanced options. - Saved state persists and can be updated without leaving the page. - Devices honor the resolved setting during provisioning. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Co-authored-by: Ian Littman <iansltx@gmail.com> |
||
|---|---|---|
| .. | ||
| activityMock.ts | ||
| appleMdm.ts | ||
| axiosError.ts | ||
| certificatesMock.ts | ||
| commonMock.ts | ||
| configMock.ts | ||
| deviceUserMock.ts | ||
| fileMock.js | ||
| hostMock.ts | ||
| idpMock.ts | ||
| labelsMock.ts | ||
| licenseMock.ts | ||
| macAdminsMock.ts | ||
| mdmMock.ts | ||
| operatingSystemsMock.ts | ||
| osqueryTableMock.ts | ||
| policyMock.ts | ||
| queryMock.ts | ||
| queryReportMock.ts | ||
| README.md | ||
| scheduleableQueryMock.ts | ||
| scriptMock.ts | ||
| setupExperienceMock.ts | ||
| softwareMock.ts | ||
| teamMock.ts | ||
| userMock.ts | ||
| vulnerabilitiesMock.ts | ||
Frontend mocks
Each __mocks___/*Mock.ts file contains one or more default mock objects and their corresponding helper function to partially override the default mock creating custom mocks.
Table of contents
- Default mocks usage -Example
- Custom mocks usage -Global handlers vs. inline handlers -Examples
- Related links
Default mocks
Default mocks are simple to work with objects. We limit the default mock to a single object that can be modified with the helper function as needed using overrides.
The default mock object is returned by calling the helper function with no arguments.
Example
A single default activity is defined in __mocks__/activityMock.ts as:
const DEFAULT_ACTIVITY_MOCK: IActivity = {
created_at: "2022-11-03T17:22:14Z",
id: 1,
actor_full_name: "Test",
actor_id: 1,
actor_gravatar: "",
actor_email: "test@example.com",
type: ActivityType.EditedAgentOptions,
};
To return this default object, call its helper function createActivityMock() with no arguments.
Custom mocks
Custom mocks are useful when we need a mock object with specific data.
Use the helper function with arguments to override the default mock data with the specific data you need.
Example
createMockActivity({ id: 2, actor_full_name: "Gabe" }) will return modifications to the DEFAULT_ACTIVITY_MOCK to override the id and actor_full_name keys only.
Related links
Check out the frontend test directory for information about our unit and integration testing layers. We use default mocks and custom mocks when mocking server requests.
Follow this guide to run tests locally.
Visit the frontend overview of Fleet UI testing for more information on our testing strategy, philosophies, and tools.