Zach Wasserman efbc2b92bb Fix race condition in updates test (#4661) ... Copy the DefaultOptions in order to prevent a data race on the Targets map. This race should only have effected testing. Race detector output: ``` WARNING: DATA RACE Read at 0x00c0000908d0 by goroutine 15: runtime.mapaccess1_faststr() /opt/hostedtoolcache/go/1.18.0/x64/src/runtime/map_faststr.go:13 +0x0 github.com/fleetdm/fleet/v4/orbit/pkg/update.TestMakeRepoPath.func1() /home/runner/work/fleet/fleet/orbit/pkg/update/update_test.go:58 +0xb6 testing.tRunner() /opt/hostedtoolcache/go/1.18.0/x64/src/testing/testing.go:1439 +0x213 testing.(*T).Run.func1() /opt/hostedtoolcache/go/1.18.0/x64/src/testing/testing.go:1486 +0x47 Previous write at 0x00c0000908d0 by goroutine 12: runtime.mapassign_faststr() /opt/hostedtoolcache/go/1.18.0/x64/src/runtime/map_faststr.go:203 +0x0 github.com/fleetdm/fleet/v4/orbit/pkg/update.TestMakeRepoPath.func1() /home/runner/work/fleet/fleet/orbit/pkg/update/update_test.go:62 +0x1cb testing.tRunner() /opt/hostedtoolcache/go/1.18.0/x64/src/testing/testing.go:1439 +0x213 testing.(*T).Run.func1() /opt/hostedtoolcache/go/1.18.0/x64/src/testing/testing.go:1486 +0x47 Goroutine 15 (running) created at: testing.(*T).Run() /opt/hostedtoolcache/go/1.18.0/x64/src/testing/testing.go:1486 +0x724 github.com/fleetdm/fleet/v4/orbit/pkg/update.TestMakeRepoPath() /home/runner/work/fleet/fleet/orbit/pkg/update/update_test.go:53 +0x1a4 testing.tRunner() /opt/hostedtoolcache/go/1.18.0/x64/src/testing/testing.go:1439 +0x213 testing.(*T).Run.func1() /opt/hostedtoolcache/go/1.18.0/x64/src/testing/testing.go:1486 +0x47 Goroutine 12 (running) created at: testing.(*T).Run() /opt/hostedtoolcache/go/1.18.0/x64/src/testing/testing.go:1486 +0x724 github.com/fleetdm/fleet/v4/orbit/pkg/update.TestMakeRepoPath() /home/runner/work/fleet/fleet/orbit/pkg/update/update_test.go:53 +0x1a4 testing.tRunner() /opt/hostedtoolcache/go/1.18.0/x64/src/testing/testing.go:1439 +0x213 testing.(*T).Run.func1() /opt/hostedtoolcache/go/1.18.0/x64/src/testing/testing.go:1486 +0x47 ```		2022-03-18 09:30:45 -07:00
..
constant	Fleetctl to package .app bundles for osquery (and changes for orbit to support them) (#4393)	2022-03-15 16:04:12 -03:00
database	Use new error handling approach in other packages (#2954)	2021-11-22 09:13:26 -05:00
insecure	Make creation of http.Client uniform across the codebase (#3097)	2021-11-24 15:56:54 -05:00
osquery	Allow disabling auto updates in fleetctl package and orbit (#4296)	2022-02-18 15:42:39 -03:00
packaging	Fleetctl to package .app bundles for osquery (and changes for orbit to support them) (#4393)	2022-03-15 16:04:12 -03:00
platform	Use new error handling approach in other packages (#2954)	2021-11-22 09:13:26 -05:00
process	Fleetctl to package .app bundles for osquery (and changes for orbit to support them) (#4393)	2022-03-15 16:04:12 -03:00
table	Fleetctl to package .app bundles for osquery (and changes for orbit to support them) (#4393)	2022-03-15 16:04:12 -03:00
update	Fix race condition in updates test (#4661)	2022-03-18 09:30:45 -07:00