mirror of
https://github.com/fleetdm/fleet
synced 2026-05-06 14:58:33 +00:00
c69d56ed64
For https://github.com/fleetdm/confidential/issues/9931.
[Here](ec3e8edbdc/docs/Contributing/Testing-and-local-development.md (L339))'s
how to test SAML locally with SimpleSAML.
- [X] Changes file added for user-visible changes in `changes/`,
`orbit/changes/` or `ee/fleetd-chrome/changes`.
See [Changes
files](https://github.com/fleetdm/fleet/blob/main/docs/Contributing/Committing-Changes.md#changes-files)
for more information.
- [x] Added/updated automated tests
- [x] A detailed QA plan exists on the associated ticket (if it isn't
there, work with the product group's QA engineer to add it)
- [x] Manual QA for all new/changed functionality
<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit
* **New Features**
* Improved SSO and SAML integration with enhanced session management
using secure cookies.
* Added support for IdP-initiated login flows.
* Introduced new tests covering SSO login flows, metadata handling, and
error scenarios.
* **Bug Fixes**
* Enhanced validation and error handling for invalid or tampered SAML
responses.
* Fixed session cookie handling during SSO and Apple MDM SSO flows.
* **Refactor**
* Replaced custom SAML implementation with the crewjam/saml library for
improved reliability.
* Simplified SAML metadata parsing and session store management.
* Streamlined SSO authorization request and response processing.
* Removed deprecated fields and redundant code related to SSO.
* **Documentation**
* Updated testing and local development docs with clearer instructions
for SSO and IdP-initiated login.
* **Chores**
* Upgraded dependencies including crewjam/saml and related packages.
* Cleaned up tests and configuration by removing deprecated fields and
unused imports.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
55 lines
1.4 KiB
Go
55 lines
1.4 KiB
Go
package httptest
|
|
|
|
import (
|
|
"bytes"
|
|
"fmt"
|
|
"io"
|
|
"net/http"
|
|
"testing"
|
|
|
|
"github.com/fleetdm/fleet/v4/server/service/middleware/endpoint_utils"
|
|
"github.com/stretchr/testify/require"
|
|
)
|
|
|
|
func DoHTTPReq(
|
|
t *testing.T,
|
|
client *http.Client,
|
|
jsonDecoder func(r io.Reader, v interface{}) error,
|
|
verb string, rawBytes []byte, urlPath string,
|
|
headers map[string]string,
|
|
expectedStatusCode int,
|
|
queryParams ...string,
|
|
) *http.Response {
|
|
requestBody := io.NopCloser(bytes.NewBuffer(rawBytes))
|
|
req, err := http.NewRequest(verb, urlPath, requestBody)
|
|
require.NoError(t, err)
|
|
for key, val := range headers {
|
|
req.Header.Add(key, val)
|
|
}
|
|
|
|
if len(queryParams)%2 != 0 {
|
|
require.Fail(t, "need even number of params: key value")
|
|
}
|
|
if len(queryParams) > 0 {
|
|
q := req.URL.Query()
|
|
for i := 0; i < len(queryParams); i += 2 {
|
|
q.Add(queryParams[i], queryParams[i+1])
|
|
}
|
|
req.URL.RawQuery = q.Encode()
|
|
}
|
|
|
|
resp, err := client.Do(req)
|
|
require.NoError(t, err)
|
|
|
|
if resp.StatusCode != expectedStatusCode {
|
|
defer resp.Body.Close()
|
|
var je endpoint_utils.JsonError
|
|
err := jsonDecoder(resp.Body, &je)
|
|
if err != nil {
|
|
t.Logf("Error trying to decode response body as Fleet jsonError: %s", err)
|
|
require.Equal(t, expectedStatusCode, resp.StatusCode, fmt.Sprintf("response: %+v", resp))
|
|
}
|
|
require.Equal(t, expectedStatusCode, resp.StatusCode, fmt.Sprintf("Fleet jsonError: %+v", je))
|
|
}
|
|
return resp
|
|
}
|