mirror of
https://github.com/fleetdm/fleet
synced 2026-05-23 17:08:53 +00:00
ab6929e71e
<!-- Add the related story/sub-task/bug number, like Resolves #123, or remove if NA --> **Related issue:** Resolves #35717 # Details This PR adds a check before enqueuing setup experience items, so that if the specified host has already been enrolled for > 24 hours we skip the setup experience. This handles the edge case where an enrolled host upgrades from an Orbit version that didn't support setup experience to one that does. # Checklist for submitter If some of the following don't apply, delete the relevant line. - [X] Changes file added for user-visible changes in `changes/`, `orbit/changes/` or `ee/fleetd-chrome/changes`. See [Changes files](https://github.com/fleetdm/fleet/blob/main/docs/Contributing/guides/committing-changes.md#changes-files) for more information. - [X] Input data is properly validated, `SELECT *` is avoided, SQL injection is prevented (using placeholders for values in statements) ## Testing - [X] Added/updated automated tests - [X] QA'd all new/changed functionality manually I didn't go through the process of getting a 1.48.1 fleetd installation on my VM, but I tested in this way: 1. Installed fleetd on a host to a team with no setup experience items 2. Manually adjusted the `last_enrolled_at` date of that host's db record to be > 24 hours in the past. 3. After enrollment, added setup experience items to that team. No setup window popped up (expected). 4. Deleted the `setup_experience.json` file on that host and restarted Orbit. 5. On `main` branch, the setup experience window popped up. When repeating these steps on this branch, no window popped up. 6. Also verified that for a new enrollment wiht `last_enrolled_at` in the last 24 hours, the setup experience window popped up as expected.
1 line
No EOL
80 B
Text
1 line
No EOL
80 B
Text
- Added logic to skip setup experience for hosts that were enrolled > 1 day ago. |