mirror of
https://github.com/fleetdm/fleet
synced 2026-05-01 18:37:37 +00:00
3fbaa2c5b7
This pull request updates the installation process for the GitHub Desktop application on macOS. The main improvement is switching the extraction method in the install script from `unzip` to `ditto` with the `--noqtn` flag, which prevents the app bundle from being quarantined after installation. This change is reflected in both the input configuration and the generated output files. **Install script improvements:** - The install script for GitHub Desktop (`github-desktop-install.sh`) now uses `ditto -xk --noqtn` instead of `unzip` to extract the application, ensuring the app is not marked as quarantined by macOS after installation. - The script logic and structure have been slightly refactored for clarity, but the core install and relaunch logic remains the same. **Configuration and reference updates:** - The `install_script_path` property was added to the Homebrew input JSON for GitHub Desktop, pointing to the new install script. - The output configuration (`darwin.json`) updates the install script reference to the new version and includes the updated script content. [[1]](diffhunk://#diff-d9d687547de8380c36144e69b184a84cbfa749eae965cab3cb313e2ff88eff20L9-R9) [[2]](diffhunk://#diff-d9d687547de8380c36144e69b184a84cbfa749eae965cab3cb313e2ff88eff20L18-R18) **Related issue:** Resolves #38679
9 lines
300 B
JSON
9 lines
300 B
JSON
{
|
|
"name": "GitHub Desktop",
|
|
"unique_identifier": "com.github.GitHubClient",
|
|
"token": "github",
|
|
"installer_format": "zip",
|
|
"slug": "github/darwin",
|
|
"default_categories": ["Developer tools"],
|
|
"install_script_path": "ee/maintained-apps/inputs/homebrew/scripts/github-desktop-install.sh"
|
|
}
|