mirror of
https://github.com/fleetdm/fleet
synced 2026-05-19 15:09:20 +00:00
Resolves #37192 Separating generic endpoint_utils middleware logic from domain-specific business logic. New bounded contexts would share the generic logic and implement their own domain-specific logic. The two approaches used in this PR are: - Use common `platform` types - Use interfaces In the next PR we will move `endpointer_utils`, `authzcheck` and `ratelimit` into `platform` directory. # Checklist for submitter - [x] Added changes file ## Testing - [x] Added/updated tests - [x] QA'd all new/changed functionality manually <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Refactor** * Restructured internal error handling and context management to support bounded context architecture. * Improved error context collection and telemetry observability through a provider-based mechanism. * Decoupled licensing and authentication concerns into interfaces for better modularity. * **Chores** * Updated internal package dependencies to align with new architectural boundaries. <sub>✏️ Tip: You can customize this high-level summary in your review settings.</sub> <!-- end of auto-generated comment: release notes by coderabbit.ai -->
236 lines
5.8 KiB
Go
236 lines
5.8 KiB
Go
package logging
|
|
|
|
import (
|
|
"context"
|
|
"errors"
|
|
"strings"
|
|
"sync"
|
|
"time"
|
|
|
|
platform_http "github.com/fleetdm/fleet/v4/server/platform/http"
|
|
kithttp "github.com/go-kit/kit/transport/http"
|
|
kitlog "github.com/go-kit/log"
|
|
"github.com/go-kit/log/level"
|
|
)
|
|
|
|
// UserEmailer provides the user's email for logging purposes.
|
|
type UserEmailer interface {
|
|
Email() string
|
|
}
|
|
|
|
type userEmailerKey struct{}
|
|
|
|
// WithUserEmailer returns a context with the UserEmailer stored for logging.
|
|
// This should be called by authentication middleware after the user is identified.
|
|
func WithUserEmailer(ctx context.Context, emailer UserEmailer) context.Context {
|
|
return context.WithValue(ctx, userEmailerKey{}, emailer)
|
|
}
|
|
|
|
// UserEmailerFromContext retrieves the UserEmailer from the context.
|
|
func UserEmailerFromContext(ctx context.Context) (UserEmailer, bool) {
|
|
v, ok := ctx.Value(userEmailerKey{}).(UserEmailer)
|
|
return v, ok
|
|
}
|
|
|
|
type key int
|
|
|
|
const loggingKey key = 0
|
|
|
|
// NewContext creates a new context.Context with a LoggingContext.
|
|
func NewContext(ctx context.Context, logging *LoggingContext) context.Context {
|
|
return context.WithValue(ctx, loggingKey, logging)
|
|
}
|
|
|
|
// FromContext returns a pointer to the LoggingContext.
|
|
func FromContext(ctx context.Context) (*LoggingContext, bool) {
|
|
v, ok := ctx.Value(loggingKey).(*LoggingContext)
|
|
return v, ok
|
|
}
|
|
|
|
// WithStartTime returns a context with logging.StartTime marked as the current time
|
|
func WithStartTime(ctx context.Context) context.Context {
|
|
if logCtx, ok := FromContext(ctx); ok {
|
|
logCtx.SetStartTime()
|
|
}
|
|
return ctx
|
|
}
|
|
|
|
// StartTime returns the start time of the context (if set).
|
|
func StartTime(ctx context.Context) (time.Time, bool) {
|
|
v, ok := ctx.Value(loggingKey).(*LoggingContext)
|
|
if !ok {
|
|
return time.Time{}, false
|
|
}
|
|
return v.StartTime, ok
|
|
}
|
|
|
|
// WithErr returns a context with logging.Err set as the error provided
|
|
func WithErr(ctx context.Context, err ...error) context.Context {
|
|
if logCtx, ok := FromContext(ctx); ok {
|
|
logCtx.SetErrs(err...)
|
|
}
|
|
return ctx
|
|
}
|
|
|
|
// WithNoUser returns a context with logging.SkipUser set to true so user won't be logged
|
|
func WithNoUser(ctx context.Context) context.Context {
|
|
if logCtx, ok := FromContext(ctx); ok {
|
|
logCtx.SetSkipUser()
|
|
}
|
|
return ctx
|
|
}
|
|
|
|
// WithExtras returns a context with logging.Extras set as the values provided
|
|
func WithExtras(ctx context.Context, extras ...interface{}) context.Context {
|
|
if logCtx, ok := FromContext(ctx); ok {
|
|
logCtx.SetExtras(extras...)
|
|
}
|
|
return ctx
|
|
}
|
|
|
|
// WithLevel forces a log level for the current request/context.
|
|
// Level may still be upgraded to Error if an error is present.
|
|
func WithLevel(ctx context.Context, level func(kitlog.Logger) kitlog.Logger) context.Context {
|
|
if logCtx, ok := FromContext(ctx); ok {
|
|
logCtx.SetForceLevel(level)
|
|
}
|
|
return ctx
|
|
}
|
|
|
|
// LoggingContext contains the context information for logging the current request
|
|
type LoggingContext struct {
|
|
l sync.Mutex
|
|
|
|
StartTime time.Time
|
|
Errs []error
|
|
Extras []interface{}
|
|
SkipUser bool
|
|
ForceLevel func(kitlog.Logger) kitlog.Logger
|
|
}
|
|
|
|
func (l *LoggingContext) SetForceLevel(level func(kitlog.Logger) kitlog.Logger) {
|
|
l.l.Lock()
|
|
defer l.l.Unlock()
|
|
l.ForceLevel = level
|
|
}
|
|
|
|
func (l *LoggingContext) SetExtras(extras ...interface{}) {
|
|
l.l.Lock()
|
|
defer l.l.Unlock()
|
|
l.Extras = append(l.Extras, extras...)
|
|
}
|
|
|
|
func (l *LoggingContext) SetSkipUser() {
|
|
l.l.Lock()
|
|
defer l.l.Unlock()
|
|
l.SkipUser = true
|
|
}
|
|
|
|
func (l *LoggingContext) SetStartTime() {
|
|
l.l.Lock()
|
|
defer l.l.Unlock()
|
|
l.StartTime = time.Now()
|
|
}
|
|
|
|
func (l *LoggingContext) SetErrs(err ...error) {
|
|
l.l.Lock()
|
|
defer l.l.Unlock()
|
|
l.Errs = append(l.Errs, err...)
|
|
}
|
|
|
|
// Log logs the data within the context
|
|
func (l *LoggingContext) Log(ctx context.Context, logger kitlog.Logger) {
|
|
l.l.Lock()
|
|
defer l.l.Unlock()
|
|
|
|
switch {
|
|
case l.setLevelError():
|
|
logger = level.Error(logger)
|
|
case l.ForceLevel != nil:
|
|
logger = l.ForceLevel(logger)
|
|
default:
|
|
logger = level.Debug(logger)
|
|
}
|
|
|
|
var keyvals []interface{}
|
|
|
|
if !l.SkipUser {
|
|
loggedInUser := "unauthenticated"
|
|
if emailer, ok := UserEmailerFromContext(ctx); ok {
|
|
loggedInUser = emailer.Email()
|
|
}
|
|
keyvals = append(keyvals, "user", loggedInUser)
|
|
}
|
|
requestMethod, ok := ctx.Value(kithttp.ContextKeyRequestMethod).(string)
|
|
if !ok {
|
|
requestMethod = ""
|
|
}
|
|
requestURI, ok := ctx.Value(kithttp.ContextKeyRequestURI).(string)
|
|
if !ok {
|
|
requestURI = ""
|
|
}
|
|
keyvals = append(keyvals, "method", requestMethod, "uri", requestURI, "took", time.Since(l.StartTime))
|
|
|
|
if len(l.Extras) > 0 {
|
|
keyvals = append(keyvals, l.Extras...)
|
|
}
|
|
|
|
if len(l.Errs) > 0 {
|
|
// Going for string concatenation here instead of json.Marshal mostly to not have to deal with error handling
|
|
// within this method. kitlog doesn't support slices of strings
|
|
var (
|
|
errs string
|
|
internalErrs string
|
|
uuids []string
|
|
)
|
|
separator := " || "
|
|
for _, err := range l.Errs {
|
|
var ewi platform_http.ErrWithInternal
|
|
if errors.As(err, &ewi) {
|
|
if internalErrs == "" {
|
|
internalErrs = ewi.Internal()
|
|
} else {
|
|
internalErrs += separator + ewi.Internal()
|
|
}
|
|
} else {
|
|
if errs == "" {
|
|
errs = err.Error()
|
|
} else {
|
|
errs += separator + err.Error()
|
|
}
|
|
}
|
|
var ewuuid platform_http.ErrorUUIDer
|
|
if errors.As(err, &ewuuid) {
|
|
if uuid := ewuuid.UUID(); uuid != "" {
|
|
uuids = append(uuids, uuid)
|
|
}
|
|
}
|
|
}
|
|
if len(errs) > 0 {
|
|
keyvals = append(keyvals, "err", errs)
|
|
}
|
|
if len(internalErrs) > 0 {
|
|
keyvals = append(keyvals, "internal", internalErrs)
|
|
}
|
|
if len(uuids) > 0 {
|
|
keyvals = append(keyvals, "uuid", strings.Join(uuids, ","))
|
|
}
|
|
}
|
|
|
|
_ = logger.Log(keyvals...)
|
|
}
|
|
|
|
func (l *LoggingContext) setLevelError() bool {
|
|
if len(l.Errs) == 0 {
|
|
return false
|
|
}
|
|
|
|
if len(l.Errs) == 1 {
|
|
var ew platform_http.ErrWithIsClientError
|
|
if errors.As(l.Errs[0], &ew) && ew.IsClientError() {
|
|
return false
|
|
}
|
|
}
|
|
|
|
return true
|
|
}
|