mirror of
https://github.com/fleetdm/fleet
synced 2026-05-16 05:28:38 +00:00
d716265641
For #27476 # Checklist for submitter - [X] Changes file added for user-visible changes in `changes/`, `orbit/changes/` or `ee/fleetd-chrome/changes`. See [Changes files](https://github.com/fleetdm/fleet/blob/main/docs/Contributing/Committing-Changes.md#changes-files) for more information. - [X] Input data is properly validated, `SELECT *` is avoided, SQL injection is prevented (using placeholders for values in statements) # Details This PR adds a new command `generate-gitops` to the `fleetctl` tool. The purpose of this command is to output GitOps-ready files that can then be used with `fleetctl-gitops`. The general usage of the command is: ``` fleectl generate-gitops --dir /path/to/dir/to/add/files/to ``` By default, the outputted files will not contain sensitive data, but will instead add comments where the data needs to be replaced by a user. In cases where sensitive data is redacted, the tool outputs warnings to the user indicating which keys need to be updated. The tool uses existing APIs to gather data for use in generating configuration files. In some cases new API client methods needed to be added to support the tool: * ListConfigurationProfiles * GetProfileContents * GetScriptContents * GetSoftwareTitleByID Additionally, the response for the /api/latest/fleet/software/batch endpoint was updated slightly to return `HashSHA256` for the software installers. This allows policies that automatically install software to refer to that software by hash. Other options that we may or may not choose to document at this time: * `--insecure`: outputs sensitive data in plaintext instead of leaving comments * `--print`: prints the output to stdout instead of writing files * `--key`: outputs the value at a keypath to stdout, e.g. `--key agent_options.config` * `--team`: only generates config for the specified team name * `--force`: overwrites files in the given directory (defaults to false, which errors if the dir is not empty) # Technical notes The command is implemented using a `GenerateGitopsCommand` type which holds some state (like a list of software and scripts encountered) as well as a Fleet client instance (which may be a mock instance for tests) and the CLI context (containing things like flags and output writers). The actual "action" of the CLI command calls the `Run()` method of the `GenerateGitopsCommand` var, which delegates most of the work to other methods like `generateOrgSettings()`, `generateControls()`, etc. Wherever possible, the subroutines use reflection to translate Go struct fields into JSON property names. This guarantees that the correct keys are written to config files, and protects against the unlikely event of keys changing. When sensitive data is encountered, the subroutines call `AddComment()` to get a new token to add to the config files. These tokens are replaced with comments like `# TODO - Add your enrollment secrets here` in the final output. # Known issues / TODOs: * The `macos_setup` configuration is not output by this tool yet. More planning is required for this. In the meantime, if the tool detects that `macos_setup` is configured on the server, it outputs a key with an invalid value and prints a warning to the user that they'll need to configure it themselves. * `yara_rules` are not output yet. The tool adds a warning that if you have Yara rules (which you can only upload via GitOps right now) that you'll have to migrate them manually. Supporting this will require a new API that we'll have to discuss the authz for, so punting on it for now. * Fleet maintained apps are not supported by GitOps yet (coming in https://github.com/fleetdm/fleet/issues/24469). In the meantime, this tool will output a `fleet_maintained_apps` key and trigger a warning, and GitOps will fail if that key is present. --------- Co-authored-by: Lucas Manuel Rodriguez <lucas@fleetdm.com> Co-authored-by: Noah Talerman <47070608+noahtalerman@users.noreply.github.com> |
||
|---|---|---|
| .. | ||
| .keep | ||
| 10098-org-logo | ||
| 19235-microsoft-compliance-conditional-access | ||
| 23497-gitops-sha | ||
| 24087-app-names | ||
| 24209-windows-mdm-error-msg | ||
| 24394-wlan-xml-profile-verification | ||
| 24475-manual_agent_install | ||
| 24878-renew-ndes | ||
| 25700-luks-escrow-longtime | ||
| 26114-new-team-with-vpp-apps | ||
| 26366-update-sql-parser | ||
| 26553-renew-digicert | ||
| 26692-upload-install-tarballs | ||
| 27003-list-host-software | ||
| 27007-host-certificate-serial-display | ||
| 27052-round-live-policy-percentages | ||
| 27436-query-automation-query-ids | ||
| 27445-webhook-automation-backend | ||
| 27458-update-calendar-events | ||
| 27463-add-script-syntax-highlighting | ||
| 27475-fix-query-page-selection-clear | ||
| 27476-add-generate-gitops-cmd | ||
| 27477-do-not-interpolate-gitops-text-sections | ||
| 27501-clear-windows-mdm-info-on-linux-enroll | ||
| 27700-validate-bootstrap-is-distribution-pkg | ||
| 27822-dep-host-cleanup | ||
| 27909-hover-checkbox-radio | ||
| 27941-GOM-shouldn't-apply-to-VPP-token | ||
| 28032-email-to-header | ||
| 28033-support-end-user-idp-fleet-vars | ||
| 28049-conditional-access-fe-updates | ||
| 28054-surface-policy-count-triggering-install | ||
| 28137-my-device-page-layout-changes | ||
| 28138-categories-be | ||
| 28154-fix-gitops-dry-run-labels | ||
| 28158-batch-script-backend | ||
| 28159-batch-scripts | ||
| 28166-webhook-logging | ||
| 28240-log-invalid-soap-msg | ||
| 28266-clean-up-settings | ||
| 28343-reverting-some-mcx-validation | ||
| 28379-vpp-app-install-status | ||
| 28411-self-service-install-status | ||
| 28443-add-hash-to-software-title-response | ||
| 28543-exe-edits | ||
| 28616-renew-custom-scep | ||
| 28619-remove-paths-err | ||
| 28743-gom-premium-only | ||
| 28747-allow-advanced-save-in-GOM | ||
| C10298-additional-stats | ||
| issue-26070-add-ui-for-manual-agent-install | ||
| issue-26148-remove-config-settings-when-no-team-removed | ||
| issue-26505-keyboard-accssibility-to-activites | ||
| issue-27198-long-host-name | ||
| issue-27775-fix-activity-date-tooltip | ||
| migration-speedup | ||
| update-go-1.24.2 | ||