mirror of
https://github.com/fleetdm/fleet
synced 2026-04-21 13:37:30 +00:00
Fixes #29894 and probably #31980. # Checklist for submitter If some of the following don't apply, delete the relevant line. - [x] Changes file added for user-visible changes in `changes/`, `orbit/changes/` or `ee/fleetd-chrome/changes`. See [Changes files](https://github.com/fleetdm/fleet/blob/main/docs/Contributing/guides/committing-changes.md#changes-files) for more information. - [x] Input data is properly validated, `SELECT *` is avoided, SQL injection is prevented (using placeholders for values in statements) ## Testing - [x] Added/updated automated tests - [x] QA'd all new/changed functionality manually
157 lines
5.6 KiB
Go
157 lines
5.6 KiB
Go
package automatic_policy
|
|
|
|
import (
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/require"
|
|
)
|
|
|
|
func TestGenerateErrors(t *testing.T) {
|
|
_, err := Generate(FullInstallerMetadata{
|
|
Title: "Foobar",
|
|
Extension: "exe",
|
|
BundleIdentifier: "",
|
|
PackageIDs: []string{"Foobar"},
|
|
})
|
|
require.ErrorIs(t, err, ErrExtensionNotSupported)
|
|
|
|
_, err = FullInstallerMetadata{}.PolicyPlatform()
|
|
require.ErrorIs(t, err, ErrExtensionNotSupported)
|
|
|
|
_, err = Generate(FullInstallerMetadata{
|
|
Title: "Foobar",
|
|
Extension: "msi",
|
|
BundleIdentifier: "",
|
|
PackageIDs: []string{""},
|
|
})
|
|
require.ErrorIs(t, err, ErrMissingProductAndUpgradeCode)
|
|
_, err = Generate(FullInstallerMetadata{
|
|
Title: "Foobar",
|
|
Extension: "msi",
|
|
BundleIdentifier: "",
|
|
PackageIDs: []string{},
|
|
})
|
|
require.ErrorIs(t, err, ErrMissingProductAndUpgradeCode)
|
|
|
|
_, err = Generate(MacInstallerMetadata{
|
|
Title: "Foobar",
|
|
BundleIdentifier: "",
|
|
})
|
|
require.ErrorIs(t, err, ErrMissingBundleIdentifier)
|
|
|
|
_, err = Generate(FullInstallerMetadata{
|
|
Title: "Foobar",
|
|
Extension: "pkg",
|
|
BundleIdentifier: "",
|
|
PackageIDs: []string{""},
|
|
})
|
|
require.ErrorIs(t, err, ErrMissingBundleIdentifier)
|
|
|
|
_, err = Generate(MacInstallerMetadata{
|
|
Title: "",
|
|
BundleIdentifier: "",
|
|
})
|
|
require.ErrorIs(t, err, ErrMissingTitle)
|
|
|
|
_, err = MacInstallerMetadata{}.PolicyQuery()
|
|
require.ErrorIs(t, err, ErrMissingBundleIdentifier)
|
|
|
|
_, err = Generate(FullInstallerMetadata{
|
|
Title: "",
|
|
Extension: "deb",
|
|
BundleIdentifier: "",
|
|
PackageIDs: []string{""},
|
|
})
|
|
require.ErrorIs(t, err, ErrMissingTitle)
|
|
|
|
_, err = Generate(FMAInstallerMetadata{})
|
|
require.ErrorIs(t, err, ErrMissingTitle)
|
|
|
|
_, err = FMAInstallerMetadata{}.PolicyDescription()
|
|
require.ErrorIs(t, err, ErrMissingTitle)
|
|
}
|
|
|
|
func TestGenerate(t *testing.T) {
|
|
policyData, err := Generate(MacInstallerMetadata{
|
|
Title: "Foobar",
|
|
BundleIdentifier: "com.foo.bar",
|
|
})
|
|
require.NoError(t, err)
|
|
require.Equal(t, "[Install software] Foobar", policyData.Name)
|
|
require.Equal(t, "Policy triggers automatic install of Foobar on each host that's missing this software.", policyData.Description)
|
|
require.Equal(t, "darwin", policyData.Platform)
|
|
require.Equal(t, "SELECT 1 FROM apps WHERE bundle_identifier = 'com.foo.bar';", policyData.Query)
|
|
|
|
policyData, err = Generate(FullInstallerMetadata{
|
|
Title: "Foobar",
|
|
Extension: "pkg",
|
|
BundleIdentifier: "com.foo.bar",
|
|
PackageIDs: []string{"com.foo.bar"},
|
|
})
|
|
require.NoError(t, err)
|
|
require.Equal(t, "[Install software] Foobar (pkg)", policyData.Name)
|
|
require.Equal(t, "Policy triggers automatic install of Foobar on each host that's missing this software.", policyData.Description)
|
|
require.Equal(t, "darwin", policyData.Platform)
|
|
require.Equal(t, "SELECT 1 FROM apps WHERE bundle_identifier = 'com.foo.bar';", policyData.Query)
|
|
|
|
// MSI with only product code
|
|
policyData, err = Generate(FullInstallerMetadata{
|
|
Title: "Barfoo",
|
|
Extension: "msi",
|
|
BundleIdentifier: "",
|
|
PackageIDs: []string{"foo"},
|
|
})
|
|
require.NoError(t, err)
|
|
require.Equal(t, "[Install software] Barfoo (msi)", policyData.Name)
|
|
require.Equal(t, "Policy triggers automatic install of Barfoo on each host that's missing this software.", policyData.Description)
|
|
require.Equal(t, "windows", policyData.Platform)
|
|
require.Equal(t, "SELECT 1 FROM programs WHERE identifying_number = 'foo';", policyData.Query)
|
|
|
|
// MSI with upgrade code
|
|
policyData, err = Generate(FullInstallerMetadata{
|
|
Title: "Barfoo",
|
|
Extension: "msi",
|
|
BundleIdentifier: "",
|
|
PackageIDs: []string{"foo"},
|
|
UpgradeCode: "bar",
|
|
})
|
|
require.NoError(t, err)
|
|
require.Equal(t, "[Install software] Barfoo (msi)", policyData.Name)
|
|
require.Equal(t, "Policy triggers automatic install of Barfoo on each host that's missing this software.", policyData.Description)
|
|
require.Equal(t, "windows", policyData.Platform)
|
|
require.Equal(t, "SELECT 1 FROM programs WHERE upgrade_code = 'bar';", policyData.Query)
|
|
|
|
policyData, err = Generate(FullInstallerMetadata{
|
|
Title: "Zoobar",
|
|
Extension: "deb",
|
|
BundleIdentifier: "",
|
|
PackageIDs: []string{"Zoobar"},
|
|
})
|
|
require.NoError(t, err)
|
|
require.Equal(t, "[Install software] Zoobar (deb)", policyData.Name)
|
|
require.Equal(t, `Policy triggers automatic install of Zoobar on each host that's missing this software.
|
|
Software won't be installed on Linux hosts with RPM-based distributions because this policy's query is written to always pass on these hosts.`, policyData.Description)
|
|
require.Equal(t, "linux", policyData.Platform)
|
|
require.Equal(t, `SELECT 1 WHERE EXISTS (
|
|
SELECT 1 WHERE (SELECT COUNT(*) FROM deb_packages) = 0
|
|
) OR EXISTS (
|
|
SELECT 1 FROM deb_packages WHERE name = 'Zoobar' AND status = 'install ok installed'
|
|
);`, policyData.Query)
|
|
|
|
policyData, err = Generate(FullInstallerMetadata{
|
|
Title: "Barzoo",
|
|
Extension: "rpm",
|
|
BundleIdentifier: "",
|
|
PackageIDs: []string{"Barzoo"},
|
|
})
|
|
require.NoError(t, err)
|
|
require.Equal(t, "[Install software] Barzoo (rpm)", policyData.Name)
|
|
require.Equal(t, `Policy triggers automatic install of Barzoo on each host that's missing this software.
|
|
Software won't be installed on Linux hosts with Debian-based distributions because this policy's query is written to always pass on these hosts.`, policyData.Description)
|
|
require.Equal(t, "linux", policyData.Platform)
|
|
require.Equal(t, `SELECT 1 WHERE EXISTS (
|
|
SELECT 1 WHERE (SELECT COUNT(*) FROM rpm_packages) = 0
|
|
) OR EXISTS (
|
|
SELECT 1 FROM rpm_packages WHERE name = 'Barzoo'
|
|
);`, policyData.Query)
|
|
}
|