mirror of
https://github.com/fleetdm/fleet
synced 2026-05-16 13:38:43 +00:00
0a8a396643
For #22787 Also revises the spec check to explain that scripts have to be defined "controls" when used in policies for the same team, with an explicit call-out for no-team.yml since this fix doesn't support pulling scripts from the global file. This is because parsing and script-matching happens early enough that we can't throw an error in the part of the code where we bail when controls are defined in both no-team and default files. To minimize diff size, we're both "passing-by-ref" and returning the maps-by-team of scripts and installers, though the former would be sufficient on its own. # Checklist for submitter If some of the following don't apply, delete the relevant line. <!-- Note that API documentation changes are now addressed by the product design team. --> - N/A Changes file added for user-visible changes in `changes/`, `orbit/changes/` or `ee/fleetd-chrome/changes`. See [Changes files](https://github.com/fleetdm/fleet/blob/main/docs/Contributing/Committing-Changes.md#changes-files) for more information. - [x] Input data is properly validated, `SELECT *` is avoided, SQL injection is prevented (using placeholders for values in statements) - [x] Added/updated tests (sorta) - [x] Manual QA for all new/changed functionality |
||
|---|---|---|
| .. | ||
| testdata | ||
| gitops.go | ||
| gitops_test.go | ||
| spec.go | ||
| spec_test.go | ||