fleet/server/service/middleware/endpoint_utils/endpoint_utils_test.go
Victor Lyuboslavsky c88cc953fb
Refactor endpoint_utils for modularization (#36484)
Resolves #37192

Separating generic endpoint_utils middleware logic from domain-specific
business logic. New bounded contexts would share the generic logic and
implement their own domain-specific logic. The two approaches used in
this PR are:
- Use common `platform` types
- Use interfaces

In the next PR we will move `endpointer_utils`, `authzcheck` and
`ratelimit` into `platform` directory.

# Checklist for submitter

- [x] Added changes file

## Testing

- [x] Added/updated tests
- [x] QA'd all new/changed functionality manually



<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

* **Refactor**
* Restructured internal error handling and context management to support
bounded context architecture.
* Improved error context collection and telemetry observability through
a provider-based mechanism.
* Decoupled licensing and authentication concerns into interfaces for
better modularity.

* **Chores**
* Updated internal package dependencies to align with new architectural
boundaries.

<sub>✏️ Tip: You can customize this high-level summary in your review
settings.</sub>

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2025-12-31 09:12:00 -06:00

125 lines
3.1 KiB
Go

package endpoint_utils
import (
"context"
"fmt"
"net/http"
"net/http/httptest"
"testing"
authz_ctx "github.com/fleetdm/fleet/v4/server/contexts/authz"
platform_http "github.com/fleetdm/fleet/v4/server/platform/http"
"github.com/go-kit/kit/endpoint"
kithttp "github.com/go-kit/kit/transport/http"
"github.com/gorilla/mux"
"github.com/stretchr/testify/require"
)
// testHandlerFunc is a handler function type used for testing.
type testHandlerFunc func(ctx context.Context, request any) (platform_http.Errorer, error)
func TestCustomMiddlewareAfterAuth(t *testing.T) {
var (
i = 0
beforeIndex = 0
authIndex = 0
afterFirstIndex = 0
afterSecondIndex = 0
)
beforeAuthMiddleware := func(next endpoint.Endpoint) endpoint.Endpoint {
return func(ctx context.Context, req interface{}) (interface{}, error) {
i++
beforeIndex = i
return next(ctx, req)
}
}
authMiddleware := func(next endpoint.Endpoint) endpoint.Endpoint {
return func(ctx context.Context, req interface{}) (interface{}, error) {
i++
authIndex = i
if authctx, ok := authz_ctx.FromContext(ctx); ok {
authctx.SetChecked()
}
return next(ctx, req)
}
}
afterAuthMiddlewareFirst := func(next endpoint.Endpoint) endpoint.Endpoint {
return func(ctx context.Context, req interface{}) (interface{}, error) {
i++
afterFirstIndex = i
return next(ctx, req)
}
}
afterAuthMiddlewareSecond := func(next endpoint.Endpoint) endpoint.Endpoint {
return func(ctx context.Context, req interface{}) (interface{}, error) {
i++
afterSecondIndex = i
return next(ctx, req)
}
}
r := mux.NewRouter()
ce := &CommonEndpointer[testHandlerFunc]{
EP: nopEP{},
MakeDecoderFn: func(iface interface{}) kithttp.DecodeRequestFunc {
return func(ctx context.Context, r *http.Request) (request interface{}, err error) {
return nopRequest{}, nil
}
},
EncodeFn: func(ctx context.Context, w http.ResponseWriter, i interface{}) error {
w.WriteHeader(http.StatusOK)
return nil
},
AuthMiddleware: authMiddleware,
CustomMiddleware: []endpoint.Middleware{
beforeAuthMiddleware,
},
CustomMiddlewareAfterAuth: []endpoint.Middleware{
afterAuthMiddlewareFirst,
afterAuthMiddlewareSecond,
},
Router: r,
}
ce.handleEndpoint("/", func(ctx context.Context, request any) (platform_http.Errorer, error) {
fmt.Printf("handler\n")
return nopResponse{}, nil
}, nil, "GET")
s := httptest.NewServer(r)
t.Cleanup(func() {
s.Close()
})
req, err := http.NewRequest("GET", s.URL+"/", nil)
require.NoError(t, err)
resp, err := http.DefaultClient.Do(req)
require.NoError(t, err)
t.Cleanup(func() {
resp.Body.Close()
})
require.Equal(t, http.StatusOK, resp.StatusCode)
require.Equal(t, 1, beforeIndex)
require.Equal(t, 2, authIndex)
require.Equal(t, 3, afterFirstIndex)
require.Equal(t, 4, afterSecondIndex)
}
type nopRequest struct{}
type nopResponse struct{}
func (n nopResponse) Error() error {
return nil
}
type nopEP struct{}
func (n nopEP) CallHandlerFunc(f testHandlerFunc, ctx context.Context, request any, svc any) (platform_http.Errorer, error) {
return f(ctx, request)
}
func (n nopEP) Service() any {
return nil
}