mirror of
https://github.com/fleetdm/fleet
synced 2026-05-06 14:58:33 +00:00
6c659050c0
<!-- Add the related story/sub-task/bug number, like Resolves #123, or remove if NA --> **Related issue:** Resolves #32220 # Details This PR fixes an issue where hosts whose running scripts were canceled by Orbit (e.g. due to timing out) were reported as being still "pending" on the batch script details view. This was due to our only counting runs as errored if the error code was > 0, and ignoring negative error codes (which is what Orbit uses for this case). # Checklist for submitter If some of the following don't apply, delete the relevant line. - [X] Input data is properly validated, `SELECT *` is avoided, SQL injection is prevented (using placeholders for values in statements) ## Testing - [X] Added/updated automated tests Changed a couple of places where we were using `1` for an error code to `-1` - [X] Where appropriate, [automated tests simulate multiple hosts and test for host isolation](https://github.com/fleetdm/fleet/blob/main/docs/Contributing/reference/patterns-backend.md#unit-testing) (updates to one hosts's records do not affect another) - [X] QA'd all new/changed functionality manually For unreleased bug fixes in a release candidate, one of: - [X] Confirmed that the fix is not expected to adversely impact load test results - [X] Alerted the release DRI if additional load testing is needed |
||
|---|---|---|
| .. | ||
| cached_mysql | ||
| failing | ||
| filesystem | ||
| mysql | ||
| mysqlredis | ||
| redis | ||
| s3 | ||