mirror of
https://github.com/fleetdm/fleet
synced 2026-05-24 09:28:54 +00:00
<!-- Add the related story/sub-task/bug number, like Resolves #123, or remove if NA --> **Related issue:** Resolves #28711 and #33685 - Adds a confirmation step to 2 run script user flows: - Host details > Actions > Run script > Actions > Run - Host details > Actions > Run script > Click script name for script details > More actions > Run - For each user flow, canceling / going back takes the user to wherever they came from, e.g., to the run script (scripts table) modal or to the script details modal - Confirming the script run always redirects to the run script (scripts table) modal - Consolidates and streamlines logic of the script modal group - Clarify + solidify modal options in script modal group <img width="1208" height="693" alt="Screenshot 2025-09-30 at 4 12 46 PM" src="https://github.com/user-attachments/assets/160d4105-cbd1-48f5-9d52-1e11f81f87f5" /> # Checklist for submitter If some of the following don't apply, delete the relevant line. - [x] Changes file added for user-visible changes in `changes/ - [x] QA'd all new/changed functionality manually <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - New Features - Added a confirmation dialog before running a script from a host’s details, clearly showing the script and host names. - Improvements - Streamlined script run flow with clearer loading indicators and smoother transitions between modals. - Enhanced modal behavior: consistent close/cancel handling and the ability to return to the previous view after canceling a run. - More consistent actions in script details and run views, reducing unexpected refreshes and interruptions. - Chores - Internal test updates to improve reliability of user interaction simulations. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Co-authored-by: Jacob Shandling <jacob@fleetdm.com>
298 lines
9.1 KiB
TypeScript
298 lines
9.1 KiB
TypeScript
import React, {
|
||
useCallback,
|
||
useContext,
|
||
useRef,
|
||
useState,
|
||
useEffect,
|
||
} from "react";
|
||
import { format } from "date-fns";
|
||
import { useQuery } from "react-query";
|
||
import FileSaver from "file-saver";
|
||
|
||
import { AppContext } from "context/app";
|
||
import { NotificationContext } from "context/notification";
|
||
import scriptAPI from "services/entities/scripts";
|
||
import { IHostScript } from "interfaces/script";
|
||
|
||
import Modal from "components/Modal";
|
||
import ModalFooter from "components/ModalFooter";
|
||
import Button from "components/buttons/Button";
|
||
import Spinner from "components/Spinner";
|
||
import Icon from "components/Icon";
|
||
import Textarea from "components/Textarea";
|
||
import CustomLink from "components/CustomLink";
|
||
import DataError from "components/DataError";
|
||
import paths from "router/paths";
|
||
import ActionsDropdown from "components/ActionsDropdown";
|
||
import { generateActionDropdownOptions } from "pages/hosts/details/HostDetailsPage/modals/RunScriptModal/ScriptsTableConfig";
|
||
import GitOpsModeTooltipWrapper from "components/GitOpsModeTooltipWrapper";
|
||
import { getPathWithQueryParams } from "utilities/url";
|
||
import { IPaginatedListScript } from "pages/hosts/ManageHostsPage/components/RunScriptBatchPaginatedList/RunScriptBatchPaginatedList";
|
||
|
||
const baseClass = "script-details-modal";
|
||
|
||
type PartialOrFullHostScript =
|
||
| Pick<IHostScript, "script_id" | "name"> // Use on Scripts page does not include last_execution
|
||
| IHostScript;
|
||
|
||
interface IScriptDetailsModalProps {
|
||
onCancel: () => void;
|
||
/** optional onClose to allow both "go back" behavior and "close" behavior depending on context */
|
||
onClose?: () => void;
|
||
onDelete?: () => void;
|
||
runScriptHelpText?: boolean;
|
||
showHostScriptActions?: boolean;
|
||
onClickRun?: (script: IHostScript) => void;
|
||
hostTeamId?: number | null;
|
||
selectedScriptId?: number;
|
||
selectedScriptDetails?: PartialOrFullHostScript | IPaginatedListScript | null;
|
||
selectedScriptContent?: string;
|
||
isLoadingScriptContent?: boolean;
|
||
isScriptContentError?: Error | null;
|
||
isHidden?: boolean;
|
||
onClickRunDetails?: (scriptExecutionId: string) => void;
|
||
teamIdForApi?: number;
|
||
suppressSecondaryActions?: boolean;
|
||
customPrimaryButtons?: React.ReactNode;
|
||
}
|
||
|
||
const ScriptDetailsModal = ({
|
||
onCancel,
|
||
onClose,
|
||
onDelete,
|
||
onClickRun,
|
||
runScriptHelpText = false,
|
||
showHostScriptActions = false,
|
||
hostTeamId,
|
||
selectedScriptId,
|
||
selectedScriptDetails,
|
||
selectedScriptContent,
|
||
isLoadingScriptContent,
|
||
isScriptContentError,
|
||
isHidden = false,
|
||
onClickRunDetails,
|
||
teamIdForApi,
|
||
suppressSecondaryActions = false,
|
||
customPrimaryButtons,
|
||
}: IScriptDetailsModalProps) => {
|
||
// For scrollable modal
|
||
const [isTopScrolling, setIsTopScrolling] = useState(false);
|
||
const topDivRef = useRef<HTMLDivElement>(null);
|
||
const checkScroll = () => {
|
||
if (topDivRef.current) {
|
||
const isScrolling =
|
||
topDivRef.current.scrollHeight > topDivRef.current.clientHeight;
|
||
setIsTopScrolling(isScrolling);
|
||
}
|
||
};
|
||
|
||
const { currentUser } = useContext(AppContext);
|
||
const { renderFlash } = useContext(NotificationContext);
|
||
|
||
// handle multiple possibilities for `selectedScriptDetails`
|
||
let scriptId: number | null = null;
|
||
if (selectedScriptId) {
|
||
scriptId = selectedScriptId;
|
||
} else if (selectedScriptDetails) {
|
||
if ("script_id" in selectedScriptDetails) {
|
||
scriptId = selectedScriptDetails.script_id;
|
||
} else if ("id" in selectedScriptDetails) {
|
||
scriptId = selectedScriptDetails.id;
|
||
}
|
||
}
|
||
|
||
const {
|
||
data: scriptContent,
|
||
error: isSelectedScriptContentError,
|
||
isLoading: isLoadingSelectedScriptContent,
|
||
} = useQuery<any, Error>(
|
||
["scriptContent", scriptId],
|
||
() =>
|
||
scriptId
|
||
? // eslint-disable-next-line @typescript-eslint/no-non-null-assertion
|
||
scriptAPI.downloadScript(scriptId)
|
||
: Promise.resolve(null),
|
||
{
|
||
refetchOnWindowFocus: false,
|
||
enabled: !selectedScriptContent && !!scriptId,
|
||
}
|
||
);
|
||
|
||
// For scrollable modal
|
||
useEffect(() => {
|
||
checkScroll();
|
||
window.addEventListener("resize", checkScroll);
|
||
return () => window.removeEventListener("resize", checkScroll);
|
||
}, [scriptContent]); // Re-run when data changes
|
||
|
||
const getScriptContent = async () => {
|
||
try {
|
||
const content = selectedScriptContent || scriptContent;
|
||
const formatDate = format(new Date(), "yyyy-MM-dd");
|
||
const filename = `${formatDate} ${
|
||
selectedScriptDetails?.name || "Script details"
|
||
}`;
|
||
const file = new File([content], filename);
|
||
FileSaver.saveAs(file);
|
||
} catch {
|
||
renderFlash("error", "Couldn’t Download. Please try again.");
|
||
}
|
||
};
|
||
|
||
const onClickDownload = () => {
|
||
if (selectedScriptContent) {
|
||
const formatDate = format(new Date(), "yyyy-MM-dd");
|
||
const filename = `${formatDate} ${selectedScriptDetails?.name}`;
|
||
const file = new File([selectedScriptContent], filename);
|
||
FileSaver.saveAs(file);
|
||
} else {
|
||
getScriptContent();
|
||
}
|
||
};
|
||
|
||
const onSelectMoreActions = useCallback(
|
||
async (action: string, script: IHostScript) => {
|
||
switch (action) {
|
||
case "showRunDetails": {
|
||
if (script.last_execution?.execution_id) {
|
||
onClickRunDetails &&
|
||
onClickRunDetails(script.last_execution?.execution_id);
|
||
}
|
||
break;
|
||
}
|
||
case "run": {
|
||
// should always be present if these actions are visible
|
||
onClickRun && onClickRun(script);
|
||
break;
|
||
}
|
||
default: // do nothing
|
||
}
|
||
},
|
||
[onClickRunDetails, onClickRun]
|
||
);
|
||
|
||
const shouldShowFooter =
|
||
!isLoadingScriptContent && selectedScriptDetails !== undefined;
|
||
|
||
const renderFooter = () => {
|
||
return (
|
||
<ModalFooter
|
||
isTopScrolling={isTopScrolling}
|
||
secondaryButtons={
|
||
suppressSecondaryActions ? undefined : (
|
||
<>
|
||
<Button
|
||
className={`${baseClass}__action-button`}
|
||
variant="icon"
|
||
onClick={() => onClickDownload()}
|
||
>
|
||
<Icon name="download" />
|
||
</Button>
|
||
<GitOpsModeTooltipWrapper
|
||
position="bottom"
|
||
renderChildren={(disableChildren) => (
|
||
<Button
|
||
disabled={disableChildren}
|
||
className={`${baseClass}__action-button`}
|
||
variant="icon"
|
||
onClick={onDelete}
|
||
>
|
||
<Icon name="trash" color="ui-fleet-black-75" />
|
||
</Button>
|
||
)}
|
||
/>
|
||
</>
|
||
)
|
||
}
|
||
primaryButtons={
|
||
customPrimaryButtons || (
|
||
<>
|
||
{showHostScriptActions && selectedScriptDetails && (
|
||
<div className={`${baseClass}__manage-automations-wrapper`}>
|
||
<ActionsDropdown
|
||
className={`${baseClass}__manage-automations-dropdown`}
|
||
onChange={(value) =>
|
||
onSelectMoreActions(
|
||
value,
|
||
selectedScriptDetails as IHostScript
|
||
)
|
||
}
|
||
placeholder="More actions"
|
||
isSearchable={false}
|
||
options={generateActionDropdownOptions(
|
||
currentUser,
|
||
hostTeamId || null,
|
||
selectedScriptDetails as IHostScript
|
||
)}
|
||
menuPlacement="top"
|
||
/>
|
||
</div>
|
||
)}
|
||
<Button onClick={onCancel}>Done</Button>
|
||
</>
|
||
)
|
||
}
|
||
/>
|
||
);
|
||
};
|
||
|
||
const renderContent = () => {
|
||
if (isLoadingScriptContent || isLoadingSelectedScriptContent) {
|
||
return <Spinner />;
|
||
}
|
||
|
||
if (isScriptContentError || isSelectedScriptContentError) {
|
||
return <DataError description="Close this modal and try again." />;
|
||
}
|
||
|
||
return (
|
||
<div
|
||
className={`${baseClass}__script-content modal-scrollable-content`}
|
||
ref={topDivRef}
|
||
>
|
||
<Textarea label="Script content:" variant="code">
|
||
{scriptContent}
|
||
</Textarea>
|
||
{runScriptHelpText && (
|
||
<div className="form-field__help-text">
|
||
To run this script on a host, go to the{" "}
|
||
<CustomLink
|
||
text="Hosts"
|
||
url={getPathWithQueryParams(paths.MANAGE_HOSTS, {
|
||
team_id: teamIdForApi,
|
||
})}
|
||
/>{" "}
|
||
page and select a host.
|
||
<br />
|
||
To run the script across multiple hosts, add a policy automation on
|
||
the{" "}
|
||
<CustomLink
|
||
text="Policies"
|
||
url={getPathWithQueryParams(paths.MANAGE_POLICIES, {
|
||
team_id: teamIdForApi,
|
||
})}
|
||
/>{" "}
|
||
page.
|
||
</div>
|
||
)}
|
||
</div>
|
||
);
|
||
};
|
||
|
||
return (
|
||
<Modal
|
||
className={baseClass}
|
||
title={selectedScriptDetails?.name || "Script details"}
|
||
width="large"
|
||
onExit={onClose ?? onCancel}
|
||
isHidden={isHidden}
|
||
>
|
||
<>
|
||
{renderContent()}
|
||
{shouldShowFooter && renderFooter()}
|
||
</>
|
||
</Modal>
|
||
);
|
||
};
|
||
|
||
export default ScriptDetailsModal;
|