mirror of
https://github.com/fleetdm/fleet
synced 2026-04-21 13:37:30 +00:00
aaac4b1dfe
<!-- Add the related story/sub-task/bug number, like Resolves #123, or remove if NA --> **Related issue:** Resolves #38889 PLEASE READ BELOW before looking at file changes Before converting individual files/packages to slog, we generally need to make these 2 changes to make the conversion easier: - Replace uses of `kitlog.With` since they are not fully compatible with our kitlog adapter - Directly use the kitlog adapter logger type instead of the kitlog interface, which will let us have direct access to the underlying slog logger: `*logging.Logger` Note: that I did not replace absolutely all uses of `kitlog.Logger`, but I did remove all uses of `kitlog.With` except for these due to complexity: - server/logging/filesystem.go and the other log writers (webhook, firehose, kinesis, lambda, pubsub, nats) - server/datastore/mysql/nanomdm_storage.go (adapter pattern) - server/vulnerabilities/nvd/* (cascades to CLI tools) - server/service/osquery_utils/queries.go (callback type signatures cascade broadly) - cmd/maintained-apps/ (standalone, so can be transitioned later all at once) Most of the changes in this PR follow these patterns: - `kitlog.Logger` type → `*logging.Logger` - `kitlog.With(logger, ...)` → `logger.With(...)` - `kitlog.NewNopLogger() → logging.NewNopLogger()`, including similar variations such as `logging.NewLogfmtLogger(w)` and `logging.NewJSONLogger(w)` - removed many now-unused kitlog imports Unique changes that the PR review should focus on: - server/platform/logging/kitlog_adapter.go: Core adapter changes - server/platform/logging/logging.go: New convenience functions - server/service/integration_logger_test.go: Test changes for slog # Checklist for submitter If some of the following don't apply, delete the relevant line. - [x] Changes file added for user-visible changes in `changes/`, `orbit/changes/` or `ee/fleetd-chrome/changes`. - Was added in previous PR ## Testing - [x] Added/updated automated tests - [x] QA'd all new/changed functionality manually <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Refactor** * Migrated the codebase to a unified internal structured logging system for more consistent, reliable logs and observability. * No user-facing functionality changed; runtime behavior and APIs remain compatible. * **Tests** * Updated tests to use the new logging helpers to ensure consistent test logging and validation. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
||
|---|---|---|
| .. | ||
| condaccess | ||
| digicert | ||
| embedded_scripts | ||
| est | ||
| hostidentity | ||
| testdata | ||
| appconfig.go | ||
| calendar.go | ||
| calendar_test.go | ||
| certificate_authorities.go | ||
| certificate_authorities_test.go | ||
| devices.go | ||
| errors.go | ||
| hosts.go | ||
| in_house_apps.go | ||
| maintained_apps.go | ||
| maintained_apps_test.go | ||
| mdm.go | ||
| mdm_export_for_test.go | ||
| mdm_external_test.go | ||
| mdm_profiles.go | ||
| mdm_test.go | ||
| orbit.go | ||
| request_certificate.go | ||
| request_certificate_test.go | ||
| scep_proxy.go | ||
| scep_proxy_test.go | ||
| scim.go | ||
| service.go | ||
| setup_experience.go | ||
| setup_experience_test.go | ||
| software.go | ||
| software_installers.go | ||
| software_installers_test.go | ||
| software_title_icons.go | ||
| teams.go | ||
| teams_test.go | ||
| testing_utils.go | ||
| users.go | ||
| users_test.go | ||
| vpp.go | ||
| vpp_test.go | ||
| vulnerabilities.go | ||