mirror of
https://github.com/fleetdm/fleet
synced 2026-04-21 21:47:20 +00:00
<!-- Add the related story/sub-task/bug number, like Resolves #123, or remove if NA --> **Related issue:** Resolves #41391 # Details This PR updates front-end API calls to use new URLs and API params, so that the front end doesn't cause deprecation warnings to appear on the server. # Checklist for submitter If some of the following don't apply, delete the relevant line. - [ ] Changes file added for user-visible changes in `changes/`, `orbit/changes/` or `ee/fleetd-chrome/changes`. See [Changes files](https://github.com/fleetdm/fleet/blob/main/docs/Contributing/guides/committing-changes.md#changes-files) for more information. n/a, should not be user-visible ## Testing - [X] Added/updated automated tests - [ ] QA'd all new/changed functionality manually The biggest risk here is not that we missed a spot that still causes a deprecation warning, but that we might inadvertently make a change that breaks the front end, for instance by sending `fleet_id` to a function that drops it silently and thus sends no ID to the server. Fortunately we use TypeScript in virtually every place affected by these changes, so the code would not compile if there were mismatches between the API expectation and what we're sending. Still, spot checking as many places as possible both for deprecation-warning leaks and loss of functionality is important. ## Summary by CodeRabbit * **Refactor** * Updated API nomenclature across the application to use "fleets" instead of "teams" and "reports" instead of "queries" in endpoint paths and request/response payloads. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
176 lines
5.1 KiB
TypeScript
176 lines
5.1 KiB
TypeScript
// for legacy legacy query stats interface
|
||
import PropTypes from "prop-types";
|
||
|
||
import { IFormField } from "./form_field";
|
||
import { IPack } from "./pack";
|
||
import {
|
||
CommaSeparatedPlatformString,
|
||
QueryablePlatform,
|
||
SelectedPlatform,
|
||
} from "./platform";
|
||
import { ILabelQuery } from "./label";
|
||
|
||
// Query itself
|
||
export interface ISchedulableQuery {
|
||
created_at: string;
|
||
updated_at: string;
|
||
id: number;
|
||
name: string;
|
||
description: string;
|
||
query: string;
|
||
team_id: number | null;
|
||
interval: number;
|
||
platform: CommaSeparatedPlatformString; // Might more accurately be called `platforms_to_query` or `targeted_platforms` – comma-separated string of platforms to query, default all platforms if omitted
|
||
min_osquery_version: string;
|
||
automations_enabled: boolean;
|
||
logging: QueryLoggingOption;
|
||
saved: boolean;
|
||
author_id: number;
|
||
author_name: string;
|
||
author_email: string;
|
||
observer_can_run: boolean;
|
||
discard_data: boolean;
|
||
packs: IPack[];
|
||
stats: ISchedulableQueryStats;
|
||
editingExistingQuery?: boolean;
|
||
labels_include_any?: ILabelQuery[];
|
||
}
|
||
|
||
export interface IEnhancedQuery extends ISchedulableQuery {
|
||
performance: PerformanceImpactIndicator;
|
||
targetedPlatforms: QueryablePlatform[];
|
||
}
|
||
export interface ISchedulableQueryStats {
|
||
user_time_p50?: number | null;
|
||
user_time_p95?: number | null;
|
||
system_time_p50?: number | null;
|
||
system_time_p95?: number | null;
|
||
total_executions?: number;
|
||
}
|
||
|
||
export const PerformanceImpactIndicatorValue = {
|
||
MINIMAL: "Minimal",
|
||
CONSIDERABLE: "Considerable",
|
||
EXCESSIVE: "Excessive",
|
||
UNDETERMINED: "Undetermined",
|
||
DENYLISTED: "Denylisted",
|
||
} as const;
|
||
|
||
export type PerformanceImpactIndicator = typeof PerformanceImpactIndicatorValue[keyof typeof PerformanceImpactIndicatorValue];
|
||
|
||
export const isPerformanceImpactIndicator = (
|
||
value: unknown
|
||
): value is PerformanceImpactIndicator => {
|
||
return Object.values(PerformanceImpactIndicatorValue).includes(
|
||
value as PerformanceImpactIndicator
|
||
);
|
||
};
|
||
|
||
// legacy
|
||
export default PropTypes.shape({
|
||
user_time_p50: PropTypes.number,
|
||
user_time_p95: PropTypes.number,
|
||
system_time_p50: PropTypes.number,
|
||
system_time_p95: PropTypes.number,
|
||
total_executions: PropTypes.number,
|
||
});
|
||
|
||
// API shapes
|
||
|
||
// Get a query by id
|
||
/** GET /api/v1/fleet/queries/{id}` */
|
||
export interface IGetQueryResponse {
|
||
query: ISchedulableQuery;
|
||
}
|
||
|
||
// List global or team queries
|
||
/** GET /api/v1/fleet/queries?order_key={column_from_queries_table}&order_direction={asc|desc}&team_id={team_id} */
|
||
export interface IListQueriesResponse {
|
||
queries: ISchedulableQuery[];
|
||
}
|
||
|
||
export interface IQueryKeyQueriesLoadAll {
|
||
scope: "queries";
|
||
teamId?: number;
|
||
page?: number;
|
||
perPage?: number;
|
||
query?: string;
|
||
orderDirection?: "asc" | "desc";
|
||
orderKey?: string;
|
||
mergeInherited?: boolean;
|
||
targetedPlatform?: SelectedPlatform;
|
||
}
|
||
// Create a new query
|
||
/** POST /api/v1/fleet/queries */
|
||
export interface ICreateQueryRequestBody {
|
||
name: string;
|
||
query: string;
|
||
description?: string;
|
||
observer_can_run?: boolean;
|
||
discard_data?: boolean;
|
||
fleet_id?: number; // global query if undefined
|
||
interval?: number; // default 0 means never run
|
||
platform?: CommaSeparatedPlatformString; // Might more accurately be called `platforms_to_query` – comma-separated string of platforms to query, default all platforms if omitted
|
||
min_osquery_version?: string; // default all versions if ommitted
|
||
automations_enabled?: boolean; // whether to send data to the configured log destination according to the query's `interval`. Default false if ommitted.
|
||
logging?: QueryLoggingOption;
|
||
labels_include_any?: string[];
|
||
}
|
||
|
||
// response is ISchedulableQuery
|
||
|
||
// Modify a query by id
|
||
/** PATCH /api/v1/fleet/queries/{id} */
|
||
export interface IModifyQueryRequestBody
|
||
extends Omit<ICreateQueryRequestBody, "name" | "query" | "fleet_id"> {
|
||
id?: number;
|
||
name?: string;
|
||
query?: string;
|
||
description?: string;
|
||
observer_can_run?: boolean;
|
||
discard_data?: boolean;
|
||
frequency?: number;
|
||
platform?: CommaSeparatedPlatformString;
|
||
min_osquery_version?: string;
|
||
automations_enabled?: boolean;
|
||
}
|
||
|
||
// response is ISchedulableQuery // better way to indicate this?
|
||
|
||
// Delete a query by name
|
||
/** DELETE /api/v1/fleet/queries/{name} */
|
||
export interface IDeleteQueryRequestBody {
|
||
fleet_id?: number; // searches for a global query if omitted
|
||
}
|
||
|
||
// Delete a query by id
|
||
// DELETE /api/v1/fleet/queries/id/{id}
|
||
// (no body)
|
||
|
||
// Delete queries by id
|
||
/** POST /api/v1/fleet/queries/delete */
|
||
export interface IDeleteQueriesRequestBody {
|
||
ids: number[];
|
||
}
|
||
|
||
export interface IDeleteQueriesResponse {
|
||
deleted: number; // number of queries deleted
|
||
}
|
||
|
||
export interface IEditQueryFormFields {
|
||
name: IFormField<string>;
|
||
description: IFormField<string>;
|
||
query: IFormField<string>;
|
||
observer_can_run: IFormField<boolean>;
|
||
discard_data: IFormField<boolean>;
|
||
frequency: IFormField<number>;
|
||
automations_enabled: IFormField<boolean>;
|
||
platforms: IFormField<CommaSeparatedPlatformString>;
|
||
min_osquery_version: IFormField<string>;
|
||
logging: IFormField<QueryLoggingOption>;
|
||
}
|
||
|
||
export type QueryLoggingOption =
|
||
| "snapshot"
|
||
| "differential"
|
||
| "differential_ignore_removals";
|