mirror of
https://github.com/fleetdm/fleet
synced 2026-04-21 21:47:20 +00:00
8b3a3cc2f3
Speculative fix for #30915 For why this is needed, see https://github.com/fleetdm/fleet/issues/30915#issuecomment-3259641371 # Checklist for submitter If some of the following don't apply, delete the relevant line. - [x] Changes file added for user-visible changes in `changes/`, `orbit/changes/` or `ee/fleetd-chrome/changes`. See [Changes files](https://github.com/fleetdm/fleet/blob/main/docs/Contributing/guides/committing-changes.md#changes-files) for more information. - [x] Input data is properly validated, `SELECT *` is avoided, SQL injection is prevented (using placeholders for values in statements) - [x] If paths of existing endpoints are modified without backwards compatibility, checked the frontend/CLI for any necessary changes ## Testing - [x] Added/updated automated tests - [x] Where appropriate, [automated tests simulate multiple hosts and test for host isolation](https://github.com/fleetdm/fleet/blob/main/docs/Contributing/reference/patterns-backend.md#unit-testing) (updates to one hosts's records do not affect another) - [x] QA'd all new/changed functionality manually <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Bug Fixes** * Improved reliability of Apple device profile installation and removal by performing coordinated, read-only transactional reads. Reduces race conditions and intermittent discrepancies during profile syncs, leading to more consistent outcomes across fleets. * **Tests** * Added tests to verify the combined install/remove results remain consistent with the individual lists, ensuring accurate and stable behavior under various state changes. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
1 line
165 B
Text
1 line
165 B
Text
* Modified the Apple profile reconciliation cron logic to query for installs and removals within a transaction to avoid race conditions around team or label changes
|