For #23243 # Checklist for submitter <!-- Note that API documentation changes are now addressed by the product design team. --> - [x] Changes file added for user-visible changes in `changes/`, `orbit/changes/` or `ee/fleetd-chrome/changes`. See [Changes files](https://github.com/fleetdm/fleet/blob/main/docs/Contributing/Committing-Changes.md#changes-files) for more information. - [x] Added/updated automated tests - [ ] A detailed QA plan exists on the associated ticket (if it isn't there, work with the product group's QA engineer to add it) - [x] Manual QA for all new/changed functionality ## Details This PR updates the policy Manage Automations modals to support pagination. Previously, these modals received a list of policies from the main Manage Policies page, which is itself paginated, so that a user could only add automations to whatever policies were currently listed on the Manage Automations page. This PR does some refactoring via the creation of a new PaginatedList component which: * accepts a `fetchPage` property it can call to get a page of data, * renders the data in a list with checkboxes and optional custom markup (e.g. dropdowns) * keeps track of changed ("dirty") items in the list, even across page changes * allows parent components to access the list of dirty items via a React `ref` For this specific use case, there's also a new `PoliciesPaginatedList` which implements the `fetchPage` for getting a page of policies, and adds Save and Cancel buttons. Each of the updated modals uses `PoliciesPaginatedList` to replace its current code for rendering policies in a list, and delegates much of the logic around change tracking to the new components. |
||
|---|---|---|
| .. | ||
| ChangeEmailForm | ||
| ChangePasswordForm | ||
| ConfirmInviteForm | ||
| ConfirmSSOInviteForm | ||
| fields | ||
| ForgotPasswordForm | ||
| FormField | ||
| LoginForm | ||
| packs | ||
| RegistrationForm | ||
| ResetPasswordForm | ||
| UserSettingsForm | ||
| validators | ||
| _styles.scss | ||
| Form.jsx | ||
| README.md | ||
Fleet Forms
Fleet Forms leverage the Form Higher Order Component to simplify implementation and state management. As a user fills out a form, the Form HOC collects the form data in state. When the form is submitted, the Form HOC calls the provided client-side validation function with the form data and, if valid, then calls the handleSubmit prop with the form data. If the client-side validation function returns errors, those errors are stored in the Form HOC state and displayed in the form input where the input name matches the error key.
The Form HOC takes 3 parameters:
- Component Class: The Component Class is the individual form component. It is a React component that renders a form.
- Options Hash: The Options Hash accepts 2 options:
fields: This option is an array of field name strings in the form.validate: This option is a function that gets called with the form data to test validity of the form. The return value from the validate function is expected to be a Javascript object with avalidkey that has a boolean value signifying whether or not the form is valid, and anerrorskey that has a Javascript object value containing the client side validation errors.
type ValidateResponse = { valid: String, errors: Object }; const validate Function = (formData: Object): ValidateResponse => { ... };
The Form HOC renders with Component Class with additional props. The added props to the form are:
fields: The fields prop is a Javascript object containing an object for eachfieldstring passed to the Form HOC in thefieldsarray. Each field object contains the following:error: A string containing client side validation errors from thevalidatefunction or from theserverErrorsprop passed to the form.name: The name of the form field.onChange: A function used to handle change on a form field element. This function stores the value of the form field element in state, and then submits the form field element values when the form is submitted.value: The value of the form field element.
Additionally, the Form HOC accepts the following props passed to the form instance:
serverErrors: A Javascript object containing errors returned by the server. The key should be the name of the form field and the value should be the error message string. (Defaults to{}).formData: A Javascript object representing the entity that will populate the form with the entity's attributes. When updating an entity, pass the entity to the form as theformDataprop.handleSubmit: A function that is called when the form is submitted. The function will be called with the form data if thevalidatefunction is run without errors.onChangeFunc: A function that is called when a form field is changed. It is passed 2 parameters, the form field name and value. This is useful for handling specific form field changes on the parent component.
Example:
// Defining the form
import Button from 'components/buttons/Button';
import Form from 'components/forms/Form';
import InputField from 'components/forms/fields/InputField';
class MyForm extends Component {
render () {
return (
<form onSubmit={this.props.handleSubmit}>
<InputField
{...this.props.fields.first_name}
/>
<InputField
{...this.props.fields.last_name}
/>
<Button type="submit" />
</form>
);
}
}
export default Form(MyForm, {
fields: ['first_name', 'last_name'],
validate: (formData) => {
return { errors: {}, valid: true };
},
});
// Rendering the form
import MyForm from 'components/forms/MyForm';
class MyFormPage extends Component {
handleSubmit = (formData) => {
console.log(formData);
}
render () {
return (
<div>
<MyForm handleSubmit={this.handleSubmit} />
</div>
);
}
}
export default MyFormPage