mirror of
https://github.com/fleetdm/fleet
synced 2026-04-21 13:37:30 +00:00
b89cc578ca
**Related issue:** Resolves #36799, Sub-task: #41556 # Checklist for submitter - [x] Changes file added for user-visible changes in `changes/`. - [x] Input data is properly validated, `SELECT *` is avoided, SQL injection is prevented (using placeholders for values in statements), JS inline code is prevented especially for url redirects ## Testing - [x] Added/updated automated tests - [x] QA'd all new/changed functionality manually <img width="924" height="278" alt="Screenshot 2026-03-16 at 10 46 38 AM" src="https://github.com/user-attachments/assets/313b6650-a849-4bc2-ba14-a62d3d13b60c" /> <img width="1441" height="300" alt="Screenshot 2026-03-16 at 10 46 44 AM" src="https://github.com/user-attachments/assets/915cfd26-168f-4621-bcf5-6c26c40e5faf" /> <img width="1923" height="788" alt="Screenshot 2026-03-16 at 10 54 04 AM" src="https://github.com/user-attachments/assets/62356a3e-84fe-4561-b7ad-0a35c9db3b2a" /> <img width="2529" height="483" alt="Screenshot 2026-03-16 at 10 47 02 AM" src="https://github.com/user-attachments/assets/4dc51073-2c24-4934-bd9d-c5ee648d5ae1" /> Tested that with latest released fleetd (1.53.0), we still ingest the available disk space. There's about 5% difference in the UI vs in the macOS "Get Info" dialog (expected, since we use the old query, now called `disk_space_darwin_legacy`): <img width="267" height="306" alt="Screenshot 2026-03-17 at 8 47 22 AM" src="https://github.com/user-attachments/assets/73fc1eef-a32c-4d8d-a9ca-13980885f8fe" /> <img width="883" height="407" alt="Screenshot 2026-03-17 at 8 47 33 AM" src="https://github.com/user-attachments/assets/98851b9b-82a8-4ac8-af5c-dbb878f85fad" /> <img width="159" height="127" alt="Screenshot 2026-03-17 at 8 47 40 AM" src="https://github.com/user-attachments/assets/209f784a-29a8-4af5-b95d-0f9bd59917c9" /> Also tested running with vanilla osquery by stopping fleetd and then running osquery manually (adding the `--allow_unsafe` flag). Result is same as above, `disk_space_darwin_legacy` is used: <img width="1152" height="418" alt="Screenshot 2026-03-17 at 8 59 23 AM" src="https://github.com/user-attachments/assets/2b34d23d-61de-4ec1-8d1c-2d3ddb682d11" /> <img width="893" height="414" alt="Screenshot 2026-03-17 at 8 59 28 AM" src="https://github.com/user-attachments/assets/d28ee8fb-08c5-434f-abfa-3825b27ac73b" /> ## Summary - Adds a new macOS-only fleetd table `disk_space` that uses `NSURLVolumeAvailableCapacityForImportantUsageKey` to report available disk capacity including purgeable storage — matching what macOS shows in Finder's "Get Info" dialog. - Adds a new `disk_space_darwin` detail query that uses the new table (with Discovery, so it only runs on hosts with fleetd ≥ 1.54.0). - Restricts the existing `disk_space_unix` query to Linux only (darwin was removed since the new query handles it). - Adds schema documentation for the new table. --------- Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
1 line
213 B
Text
1 line
213 B
Text
* Added a new `disk_space` fleetd table for macOS that reports available disk space including purgeable storage, matching the value shown in Finder's "Get Info" dialog and System Settings → General → Storage.
|