mirror of
https://github.com/fleetdm/fleet
synced 2026-04-21 13:37:30 +00:00
Add lock semantics around dev_mode.IsEnabled to as a fix for [this](https://github.com/fleetdm/fleet/actions/runs/23728512273) data race
66 lines
1.4 KiB
Go
66 lines
1.4 KiB
Go
package dev_mode
|
|
|
|
import (
|
|
"os"
|
|
"sync"
|
|
"testing"
|
|
)
|
|
|
|
// IsEnabled should be configured once at process startup (e.g., via flags) and then treated as read-only.
|
|
// It must not be written from concurrent goroutines; SetOverride only affects enabledViaOverride/env overrides.
|
|
var IsEnabled bool
|
|
|
|
// enabledViaOverride is set by SetOverride and protected by mu so that it is
|
|
// always observed consistently with envOverrides.
|
|
var enabledViaOverride bool
|
|
|
|
var mu sync.RWMutex
|
|
|
|
var envOverrides = map[string]string{}
|
|
|
|
type GetEnv func(name string) string
|
|
|
|
func Env(name string) string {
|
|
mu.RLock()
|
|
defer mu.RUnlock()
|
|
|
|
if !IsEnabled && !enabledViaOverride {
|
|
return ""
|
|
}
|
|
|
|
if override, ok := envOverrides[name]; ok {
|
|
return override
|
|
}
|
|
|
|
return os.Getenv(name)
|
|
}
|
|
|
|
func SetOverride(name string, value string, cleanup ...*testing.T) { // optional parameter to reset on test cleanup
|
|
if len(cleanup) > 0 {
|
|
cleanup[0].Setenv("FLEET_DEV_OVERRIDE_SET", "1") // triggers test deny-parallel check
|
|
cleanup[0].Cleanup(func() {
|
|
ClearOverride(name)
|
|
})
|
|
}
|
|
|
|
mu.Lock()
|
|
defer mu.Unlock()
|
|
|
|
enabledViaOverride = true // if we're setting overrides, we're in a test environment so want to turn dev mode on
|
|
envOverrides[name] = value
|
|
}
|
|
|
|
func ClearOverride(name string) {
|
|
mu.Lock()
|
|
defer mu.Unlock()
|
|
|
|
delete(envOverrides, name)
|
|
}
|
|
|
|
func ClearAllOverrides() {
|
|
mu.Lock()
|
|
defer mu.Unlock()
|
|
|
|
enabledViaOverride = false
|
|
envOverrides = map[string]string{}
|
|
}
|