mirror of
https://github.com/fleetdm/fleet
synced 2026-05-18 22:49:19 +00:00
<!-- Add the related story/sub-task/bug number, like Resolves #123, or remove if NA --> **Related issue:** Resolves #32632 # Details This PR updates the Script Library page in the following ways: * When no scripts are uploaded for a team, it shows the "Add script" UI with a button that opens a new "Add Script" modal * When scripts are uploaded, the "Add script" button is instead added to the header of the scripts list, and clicking it opens that modal # Checklist for submitter If some of the following don't apply, delete the relevant line. - [X] Changes file added for user-visible changes in `changes/`, `orbit/changes/` or `ee/fleetd-chrome/changes`. See [Changes files](https://github.com/fleetdm/fleet/blob/main/docs/Contributing/guides/committing-changes.md#changes-files) for more information. ## Testing - [ ] Added/updated automated tests working on this - [X] QA'd all new/changed functionality manually - [X] Test empty state: go to controls/scripts/library for a team with no scripts. Clicking "upload" button in empty state should open the add script modal. - [X] In the modal, select a .ps1 script. Should not see additional text. - [X] Close modal without uploading. Re-open. File field should be cleared & upload button visible again. - [X] Select a .sh script. Should see additional text about macOS and Linux. - [X] Add script. Make sure script saves and modal closes. - [X] Once script has been added, make sure empty state is gone and "Add script" button is at the top of the list. - [X] Go to /controls/os-settings/custom-settings for a team with no profiles uploaded. Make sure empty state text styles match the empty state for script uploads. - [X] Open modal to add profile. Make sure upload text styles match the script upload modal. - [X] Enable GitOps mode. Go to controls/scripts/library for a team with scripts added. Make sure new "Add script" button is disabled w/ standard tooltip in GitOps mode. Scripts empty state: <img width="697" height="352" alt="image" src="https://github.com/user-attachments/assets/32f0f246-bddb-4bb7-bc39-48d9978de9fa" /> Scripts uploader: <img width="745" height="590" alt="image" src="https://github.com/user-attachments/assets/f82414e2-9318-4543-b5ca-41e759662587" /> Scripts uploader with .sh <img width="750" height="539" alt="image" src="https://github.com/user-attachments/assets/0b989067-921a-4d18-93ed-09aac90fc9cb" /> Scripts table: <img width="686" height="256" alt="image" src="https://github.com/user-attachments/assets/848f1b56-6e9e-48d4-9a03-6fdf5427301e" /> Profiles empty state: <img width="700" height="377" alt="image" src="https://github.com/user-attachments/assets/8f92bcd9-2215-41f6-a540-4774f7e9542b" /> Profiles uploader: <img width="707" height="682" alt="image" src="https://github.com/user-attachments/assets/eef216af-3447-48e7-882a-e42e888e1c17" />
47 lines
1.3 KiB
TypeScript
47 lines
1.3 KiB
TypeScript
import React, { useContext, useState } from "react";
|
|
|
|
import FileUploader from "components/FileUploader";
|
|
import { getFileDetails } from "utilities/file/fileUtils";
|
|
|
|
const baseClass = "script-uploader";
|
|
|
|
interface IScriptPackageUploaderProps {
|
|
onFileSelected?: (file: File) => void;
|
|
selectedFile?: File | null;
|
|
forModal?: boolean;
|
|
onButtonClick?: () => void;
|
|
}
|
|
|
|
const ScriptPackageUploader = ({
|
|
forModal,
|
|
onFileSelected,
|
|
selectedFile,
|
|
onButtonClick,
|
|
}: IScriptPackageUploaderProps) => {
|
|
const onFileSelect = (files: FileList | null) => {
|
|
if (files && files.length > 0) {
|
|
onFileSelected?.(files[0]);
|
|
}
|
|
};
|
|
|
|
const buttonType = forModal ? "brand-inverse-icon" : undefined;
|
|
const buttonMessage = forModal ? "Choose file" : "Add script";
|
|
|
|
return (
|
|
<FileUploader
|
|
className={baseClass}
|
|
graphicName={["file-sh", "file-ps1"]}
|
|
message="Shell (.sh) for macOS and Linux or PowerShell (.ps1) for Windows"
|
|
title="Upload script"
|
|
accept=".sh,.ps1"
|
|
onFileUpload={onFileSelect}
|
|
fileDetails={selectedFile ? getFileDetails(selectedFile) : undefined}
|
|
buttonType={buttonType}
|
|
buttonMessage={buttonMessage}
|
|
gitopsCompatible
|
|
onButtonClick={onButtonClick}
|
|
/>
|
|
);
|
|
};
|
|
|
|
export default ScriptPackageUploader;
|