mirror of
https://github.com/fleetdm/fleet
synced 2026-04-21 21:47:20 +00:00
7a46fa2f22
- Replace json.MarshalIndent with json.Encoder using SetEscapeHTML(false) - Fixes both processOutput() and updateAppsListFile() functions - Add test to verify HTML characters are preserved - Regenerate yubico-yubikey-manager manifest to demonstrate fix Previously, HTML tags and special characters (<, >, &) were being escaped as Unicode sequences (\u003c, \u003e, \u0026) in JSON output. This affected both app descriptions with HTML links and shell scripts with redirect operators.
47 lines
1.3 KiB
Go
47 lines
1.3 KiB
Go
package main
|
|
|
|
import (
|
|
"bytes"
|
|
"encoding/json"
|
|
"strings"
|
|
"testing"
|
|
)
|
|
|
|
func TestJSONEncoderPreservesHTML(t *testing.T) {
|
|
testData := struct {
|
|
Description string `json:"description"`
|
|
}{
|
|
Description: `Test with HTML: <a href="https://example.com">link</a> & special chars < >`,
|
|
}
|
|
|
|
// Test with SetEscapeHTML(false)
|
|
var buf bytes.Buffer
|
|
encoder := json.NewEncoder(&buf)
|
|
encoder.SetEscapeHTML(false)
|
|
if err := encoder.Encode(testData); err != nil {
|
|
t.Fatalf("Failed to encode: %v", err)
|
|
}
|
|
|
|
result := buf.String()
|
|
|
|
// Verify HTML characters are preserved, not escaped
|
|
if strings.Contains(result, `\u003c`) {
|
|
t.Error("Found escaped '<' character (\\u003c) - HTML escaping is still enabled")
|
|
}
|
|
if strings.Contains(result, `\u003e`) {
|
|
t.Error("Found escaped '>' character (\\u003e) - HTML escaping is still enabled")
|
|
}
|
|
if strings.Contains(result, `\u0026`) {
|
|
t.Error("Found escaped '&' character (\\u0026) - HTML escaping is still enabled")
|
|
}
|
|
|
|
// Verify HTML characters are present (note: quotes inside JSON are still escaped)
|
|
if !strings.Contains(result, `<a href=\"https://example.com\">`) {
|
|
t.Error("HTML anchor tag was not preserved correctly")
|
|
}
|
|
if !strings.Contains(result, ` & `) {
|
|
t.Error("Ampersand character was not preserved correctly")
|
|
}
|
|
|
|
t.Logf("Successfully preserved HTML in JSON output: %s", result)
|
|
}
|