fleet/changes
Jacob Shandling 67c45d5417
UI – refactor forms and form fields (#16159)
## Addresses #15325 

- Define shared global styles for forms (`form` and `.form`s) and
`.form-field`s
- Sweep through the app, updating each form from being locally styled to
first prioritizing the global styles and only defining local styles
where needed for custom behavior
- Remove lots of unnecessary nesting of elements
- Other small bug fixes and improvements

### Samples, before (L) | after (R):
**Save query modal**
![Screenshot 2024-01-17 at 11 49
14 AM](https://github.com/fleetdm/fleet/assets/61553566/14f209fb-31db-41ef-8e63-e0d8994698c1)

**Edit query form**
![Screenshot 2024-01-17 at 11 50
35 AM](https://github.com/fleetdm/fleet/assets/61553566/b07e70ea-3095-4e4f-be73-95a3c499839b)

**Add hosts modal**
![Screenshot 2024-01-17 at 11 51
48 AM](https://github.com/fleetdm/fleet/assets/61553566/4ef1f410-a823-41d1-b2f6-ea8eb5231f93)


## QA Plan:
@xpkoala here's the same list from the issue, freshly de-checked for you
to use if it's helpful:
* Please check error states of each field

#### Specified by issue:
##### In "Save query" modal:
- [ ] Reduce space between checkboxes and their help text to 8px/0.5rem
for the following fields:
   - [ ] Observers can run
   - [ ] Discard data 
- [ ] Update the following checkbox labels to have normal font weight
(not bold):
   - [ ]  Discard data

##### On "Edit query" page:
- [ ] Update the following checkbox labels to have normal font weight
(not bold):
   - [ ] Observers can run
   - [ ] Discard data

##### In "Add hosts" modal, for copy text fields: 
- [ ]  match typical form form field styles
- [ ] Adjust the positioning of the copy icon to keep it from being too
far down

##### Further locations to check
- [ ] ChangeEmailForm.jsx 
- [ ] ChangePasswordForm.jsx 
- [ ] ConfirmInviteForm.jsx 
- [ ] ConfirmSSOInviteForm.jsx
- [ ] EnrollSecretModal.tsx
- [ ] ForgotPasswordForm.jsx
- [ ] LoginForm.tsx
- [ ] EditPackForm.tsx
- [ ] (New)PackForm.tsx
- [ ] AdminDetails.jsx
- [ ] ConfirmationPage.tsx
- [ ] FleetDetails.jsx
- [ ] OrgDetails.jsx
- [ ] ResetPasswordForm.tsx
- [ ] UserSettingsForm.jsx
- [ ] EditTeamModal.tsx
- [ ] IdpSection.tsx 
- [ ] DeleteIntegrationModal.tsx
- [ ] IntegrationForm.tsx 
- [ ] EndUserMigrationSection.tsx
- [ ] RequestCSRModal.tsx
- [ ] Advanced.tsx 
- [ ] Agents.tsx 
- [ ] FleetDesktop.tsx
- [ ] HostStatusWebhook.tsx front
- [ ] Info.tsx 
- [ ] Smtp.tsx 
- [ ] Sso.tsx 
- [ ] Statistics.tsx
- [ ] WebAddress.tsx
- [ ] CreateTeamModal.tsx
- [ ] DeleteTeamModal.tsx
- [ ] EditTeamModal.tsx
- [ ] AgentOptionsPage.tsx
- updated the layout of this page to align with the rest of the forms in
the UI – can easily revert if it's not what we want
- [ ] AddMemberModal.tsx
- [ ] RemoveMemberModal.tsx
- [ ] UserForm.tsx 
  - Used by both `EditUserModal` and `CreateUserModal`
  - A few different conditions that cause different rendering behavior 
- [ ] DeleteHostModal.tsx
- [ ] TransferHostModal.tsx
- [ ] LabelForm.tsx
- [ ] MacOSTargetForm.tsx
- [ ] WindowsTargetForm.tsx 
- [ ] BootstrapPackageListltem.ts
- [ ] EndUserAuthForm.tsx
- [ ] PackQueryEditorModal.tsx
- [ ] PolicyForm.tsx 
- [ ] SaveNewPolicyModal.tsx
- [ ] ConfirmSaveChangesModal.tsx
- [ ] Query automations modal
- [ ] Policy automations modal - addresses #16010 
- [ ] SoftwareAutomationsModal

## Checklist for submitter
- [x] Changes file added for user-visible changes in `changes/`
- [x] Manual QA for all new/changed functionality

---------

Co-authored-by: Jacob Shandling <jacob@fleetdm.com>
Co-authored-by: RachelElysia <71795832+RachelElysia@users.noreply.github.com>
2024-01-18 10:48:44 -05:00
..
.keep Issue 1009 calculate diff software (#1305) 2021-07-08 13:57:43 -03:00
10379-list-failing-policies-first On My device and Host details pages, failing policies are now listed first. (#16102) 2024-01-16 10:19:16 -06:00
13832-enroll-secret-in-keychain Enroll secret in macOS keychain and Windows Credential Manager (#16068) 2024-01-16 06:51:37 -06:00
14984-observer-plus-cta-wording Fleet UI: Update Observer+ CTA for live query button (#15982) 2024-01-10 11:36:35 -05:00
15268-osquery-perf-fix osquery-perf to return expected win version data (#15909) 2024-01-12 06:08:33 -07:00
15325-form-styles UI – refactor forms and form fields (#16159) 2024-01-18 10:48:44 -05:00
15408-fix-windows-mdm-poll-interval Fix polling schedule for Windows MDM (#16104) 2024-01-16 09:05:19 -05:00
15490-query-reports-support-custom-pack_delimiter Add support for custom pack_delimiter to query reports (#16162) 2024-01-18 12:41:06 -03:00
15538-ms-teams fix: false positives on ms teams on macos (#16048) 2024-01-11 11:56:27 -05:00
15732-table-loading Fleet UI: Consistent loading spinner when using search filter on tables (#16130) 2024-01-17 10:35:58 -05:00
15783-active-link-returns-default Fleet UI: Clicking an active nav link will navigate/reset to default page (#16081) 2024-01-16 09:25:01 -05:00
15887-improve-ux-for-globally-disabling-sso Improve UX for globally enabling/disabling SSO (#15887) 2024-01-10 08:26:55 -06:00
15890-warning-when-downgrading Added warning/info messages when downgrading/upgrading fleetd or osquery. (#15944) 2024-01-10 08:27:10 -06:00
15896-settings-header-styling Fleet UI: Globally style settings max-width to 754px (#16002) 2024-01-10 13:20:32 -05:00
15902-update-page-titles Fleet UI: Update page titles (#15983) 2024-01-12 09:27:56 -05:00
15903-bug-resolved-in fix vulnerabilities resolved in value (#15905) 2024-01-11 09:22:35 -07:00
15916-client-errors prevent baseClient from trying to decode 204 responses (#16060) 2024-01-11 17:55:35 -03:00
15996-fix-svg-fill-empty-members Fleet UI: Make SVG ids unique to fix missing empty members image (#16053) 2024-01-11 15:57:57 -05:00
15998-empty-state-styling Fleet UI: Fix empty state width causing center misalignment (#16128) 2024-01-17 10:35:36 -05:00
16056-empty-browser-property For software/titles and software/versions endpoints, the browser property is no longer included in the response when empty. (#16126) 2024-01-16 10:33:03 -06:00
config-web-url allow to configure a custom configuration_web_url (#16175) 2024-01-17 19:47:04 -03:00
issue-16031-os-updates-free-ui Add free tier UI states os updates and setup experience pages (#16160) 2024-01-18 10:54:51 +00:00