fleet/changes/24720-msi-large-interned-strings at 5cbf1fa3fcaf086cc5ccdcd7c6525bb237ed7fac - Elgato_dark/fleet - Forgejo: Beyond coding. We Forge.

Elgato_dark/fleet

mirror of https://github.com/fleetdm/fleet synced 2026-05-21 07:58:31 +00:00

Ian Littman 5beeb248f7

Handle long interned strings in MSI parsing (#25079 )

For #24720. Used
https://github.com/ChaelChu/msi-props-reader/blob/master/src/msiPropsReader.ts
as inspiration. Not sure why the shift is 17 bits rather than 16 here
but confirmed that 17 works and 16 doesn't.

Tested against both existing GDrive MSIs for regression testing, plus
the one mentioned in the ticket.

# Checklist for submitter

If some of the following don't apply, delete the relevant line.

<!-- Note that API documentation changes are now addressed by the
product design team. -->

- [x] Changes file added for user-visible changes in `changes/`,
`orbit/changes/` or `ee/fleetd-chrome/changes`.
See [Changes
files](https://github.com/fleetdm/fleet/blob/main/docs/Contributing/Committing-Changes.md#changes-files)
for more information.
- [x] Manual QA for all new/changed functionality

2025-01-02 10:41:08 -06:00

1 line

115 B

Text

Raw Blame History

* Fixed MSI parsing for packages including long interned strings (e.g. licenses for the OpenVPN Connect installer)