mirror of
https://github.com/fleetdm/fleet
synced 2026-05-06 06:48:54 +00:00
59a73b1e47
**Related issue:** Resolves #32084 This PR modifies `isValidAppFilePath` to allow subdirectors in `Applications/`, like in this case `Applications/Cisco/Cisco Secure Client.app`. This also changes the metadata extraction from packageinfo to trim `.app` from the name in all cases. # Checklist for submitter If some of the following don't apply, delete the relevant line. - [x] Changes file added for user-visible changes in `changes/`, `orbit/changes/` or `ee/fleetd-chrome/changes`. See [Changes files](https://github.com/fleetdm/fleet/blob/main/docs/Contributing/guides/committing-changes.md#changes-files) for more information. - [ ] Input data is properly validated, `SELECT *` is avoided, SQL injection is prevented (using placeholders for values in statements) - [ ] If paths of existing endpoints are modified without backwards compatibility, checked the frontend/CLI for any necessary changes ## Testing - [x] Added/updated automated tests - [ ] Where appropriate, [automated tests simulate multiple hosts and test for host isolation](https://github.com/fleetdm/fleet/blob/main/docs/Contributing/reference/patterns-backend.md#unit-testing) (updates to one hosts's records do not affect another) - [x] QA'd all new/changed functionality manually ### Test plan: --- I ran this on my local environment and it seemed fine - Have environment with the bug recreated, it has two software titles for "Cisco Secure Client", and the one with the bundle id `com.cisco.pkg.anyconnect.vpn` is used by the installer. - URL to pkg: https://fndtnfleetmsp.blob.core.windows.net/fndtnpkgs/cisco-secure-client-macos-5.1.3.62-core-vpn-webdeploy-k9.pkg - Cisco Secure Client doesn't show as installed in UI even after installing. - Run the new migration. - Cisco Secure Client shows as installed now in ui, software title with bundle id `com.cisco.pkg.anyconnect.vpn` is gone from the database, and the software installer references the correct title (`com.cisco.secureclient.gui`). - Check that deleting and reuploading the installer doesn't recreate the bad software title. ### QA Note: --- There are some problems with the install script, but that is probably a different scope than this ticket. `Reinstall` wont work, it says Cisco Secure Client is already installed. Uninstalling through Fleet then Installing again works fine though. |
||
|---|---|---|
| .. | ||
| .keep | ||
| 22463-jetbrains | ||
| 26879-add-sticky-enrollment-redis-key | ||
| 26912-custom-scep-windows | ||
| 28070-device-mapping | ||
| 28388-whatsapp-vscode-icons | ||
| 28711-confirm-script-runs | ||
| 28713-gitops-checkbox-status-does-not-stay | ||
| 29086-fix-windows-wipe-reenroll-as-new-host | ||
| 30523-ui-settings-integrations-spacing | ||
| 30889-enable-lost-mode-ios-ipados | ||
| 30890-added-install-software-ios-ipados | ||
| 31010-santa-tables | ||
| 31082-logi-bolt-false-positive | ||
| 31083-add-missing-activities-for-canceled-vpp-app-installs | ||
| 31083-fix-inconsistent-software-title-status-counts | ||
| 31110-add-require-all-software-flag | ||
| 31397-vscode-extensions | ||
| 31671-gigs-all-disk-space | ||
| 31970-npm | ||
| 32082-validate-vpp-app-vs-software-installer-conflicts | ||
| 32084-cisco-secure-client | ||
| 32178-software-vuln-perf | ||
| 32229-show-flash-warning-unauth-settings-access | ||
| 32266-jetbrains-plugin-vulns | ||
| 32399-ui-bugfix-show-de-key | ||
| 32432-fail-dry-run-vpp-token-not-found | ||
| 32499-apple-mdm-host-expiry | ||
| 32632-update-add-scripts-ui | ||
| 32635-hide-count-and-versions-when-no-hosts-installed | ||
| 32751-installer-not-found | ||
| 32948-post-install-output | ||
| 33054-gitops-license-warning | ||
| 33068-ui-absolute-timestamps | ||
| 33111-stop-setup-on-software-failure | ||
| 33111-update-macos-setup-experience | ||
| 33136-custom-organization-logo-bug | ||
| 33149-bugfix-nil-point-batch-profiles | ||
| 33173-update-setting-up-your-device | ||
| 33199-gitops-pluralization | ||
| 33235-vscode-golang-ext-false-positives | ||
| 33245-33065-fix-builtin-labels | ||
| 33249-link-between-query-report-and-host-details | ||
| 33254-prevent-lingering-redis-keys | ||
| 33393-show-status-conts-on-batch-scr-detail-page-tabs | ||
| 33410-list-hosts-software-sha256 | ||
| 33447-better-api-error-for-eua-manual-macos-profile | ||
| 33492-host-count-mismatch | ||
| 33494-os-version-response-time | ||
| 33502-longer-vars-not-processed-in-right-order | ||
| 33513-host-deleted-activity | ||
| 33572-add-new-server-flag-cleanup-age | ||
| 33580-ui-android-software | ||
| 33581-android-sw-ingestion | ||
| 33665-custom-os-updates-and-filevault | ||
| 33677-generate-gitops-fix | ||
| 33681-software-ingestion-dbg-msg | ||
| 33790-setup-software-install-order | ||
| 34086-policy-query-editability | ||
| 34116-cert-source-deadlocks | ||
| 34217-host-identity-ca | ||
| 34500-os-versions | ||
| 34530-setup-experience-style-updates | ||
| 34621-dark-logo-copy | ||
| 34697-batch-script-page-copy | ||
| 34768-go-1.25.3 | ||
| 34801-remove-premium-check-for-os-settings | ||
| 332661-certs-renewal-ou | ||
| issue-32902-allow-file-contact-url | ||
| issue-33417-ui-for-lock-unlock-ios | ||
| issue-33701-ui-install-software-ios-ipad | ||