fleet/changes/16076-ping-endpoints-not-rate-limit at 56fd2f1d8a8bbe7369637566b79fcaf155dc0d9f - Elgato_dark/fleet - Forgejo: Beyond coding. We Forge.

Elgato_dark/fleet

mirror of https://github.com/fleetdm/fleet synced 2026-05-23 08:58:41 +00:00

Lucas Manuel Rodriguez c46b6bdbbe

Remove ineffective rate limit to /api/fleet/device/ping and api/fleet/orbit/ping endpoints (#16334 )

#16076

This change removes ineffective rate limit to `/api/fleet/device/ping`
and `api/fleet/orbit/ping`.
Currently these endpoints are not rate limited, because the rate
limiting used in these was the `errorLimiter` which only takes effect if
the request fails and the ping endpoints never fail. So... we were
making ineffective Redis accesses on every `/api/fleet/device/ping` and
`api/fleet/orbit/ping` requests (we use Redis as the limiter store).

- [X] Changes file added for user-visible changes in `changes/` or
`orbit/changes/`.
See [Changes
files](https://fleetdm.com/docs/contributing/committing-changes#changes-files)
for more information.
- [x] Manual QA for all new/changed functionality

2024-01-25 15:05:52 -03:00

1 line

104 B

Text

Raw Blame History

* Remove ineffective rate-limiting from `/api/fleet/orbit/ping` and `/api/fleet/device/ping` endpoints.