fleet/changes/30199-stmt-tweak at 48ea14abbdfd3b2f7a1b0d32d3be7da4f2a56837 - Elgato_dark/fleet - Forgejo: Beyond coding. We Forge.

Elgato_dark/fleet

mirror of https://github.com/fleetdm/fleet synced 2026-05-22 00:18:27 +00:00

Ian Littman 2e58aabeee

Avoid unnecessary prepared statements in "select config from team" uncached queries (#30206 )

For #30199. This is one of a few approaches to mitigate the issue the
customer is seeing.

This is SQLi-safe because we're dealing with an unsigned int parameter,
sprintf'd %d. Existing tests fully cover this path.

# Checklist for submitter

<!-- Note that API documentation changes are now addressed by the
product design team. -->

- [x] Changes file added for user-visible changes in `changes/`,
`orbit/changes/` or `ee/fleetd-chrome/changes`.
See [Changes
files](https://github.com/fleetdm/fleet/blob/main/docs/Contributing/guides/committing-changes.md#changes-files)
for more information.
- [x] Input data is properly validated, `SELECT *` is avoided, SQL
injection is prevented (using placeholders for values in statements)
- [ ] Manual QA for all new/changed functionality

2025-06-23 21:09:55 -05:00

1 line

99 B

Text

Raw Blame History

* Improved performance when pulling team settings on osquery config and distributed read endpoints