fleet/server/service/validation_setup.go
Zach Wasserman 233cce6120
Handle missing server_url in setup (#1093)
Improve error handling to avoid a nil pointer panic in the setup endpoint.
2021-06-15 11:25:52 -07:00

38 lines
989 B
Go

package service
import (
"context"
"errors"
"net/url"
"github.com/fleetdm/fleet/server/fleet"
)
func (mw validationMiddleware) NewAppConfig(ctx context.Context, payload fleet.AppConfigPayload) (*fleet.AppConfig, error) {
invalid := &fleet.InvalidArgumentError{}
var serverURLString string
if payload.ServerSettings == nil || payload.ServerSettings.ServerURL == nil ||
*payload.ServerSettings.ServerURL == "" {
invalid.Append("server_url", "missing required argument")
} else {
serverURLString = cleanupURL(*payload.ServerSettings.ServerURL)
}
if err := validateServerURL(serverURLString); err != nil {
invalid.Append("server_url", err.Error())
}
if invalid.HasErrors() {
return nil, invalid
}
return mw.Service.NewAppConfig(ctx, payload)
}
func validateServerURL(urlString string) error {
serverURL, err := url.Parse(urlString)
if err != nil {
return err
}
if serverURL.Scheme != "https" {
return errors.New("url scheme must be https")
}
return nil
}