mirror of
https://github.com/fleetdm/fleet
synced 2026-05-21 07:58:31 +00:00
41fd8409e9
# Overview This PR implements the S3 upload manager under-the-hood of our `datastore/s3` client's `Put()` method. # Description As surfaced by #31667, the current S3 implementation utilizes the `PUT` operation which means services, such as MinIO, take issue with attempted uploads that are [too large](https://github.com/minio/minio/blob/master/cmd/streaming-signature-v4.go#L260). The `PUT` operation can also present challenges in memory-constrained environments as the entire upload target is read into memory before it's shipped. # Notes - See the `TODO` comment section, there's more cool stuff we can and should do with this in the future! # Standard Pull Request Details ## Testing - [x] QA'd all new/changed functionality manually For unreleased bug fixes in a release candidate, one of: - [x] Confirmed that the fix is not expected to adversely impact load test results --------- Signed-off-by: Illbjorn <am@hades.so> |
||
|---|---|---|
| .. | ||
| cached_mysql | ||
| filesystem | ||
| mysql | ||
| mysqlredis | ||
| redis | ||
| s3 | ||