mirror of
https://github.com/fleetdm/fleet
synced 2026-05-01 18:37:37 +00:00
<!-- Add the related story/sub-task/bug number, like Resolves #123, or remove if NA --> **Related issue:** Resolves #34596 # Details This PR adds back the "legacy" macOS setup experience, and a new `CapabilityMacOSWebSetupExperience` capability check. The legacy experience will be shown whenever the `CapabilityMacOSWebSetupExperience` capability is _not_ detected in the Fleet server response. The majority of the code is just copying the `Run` and `startSwiftDialog` from the [4.75.1 patch release](https://github.com/fleetdm/fleet/blob/rc-patch-fleet-v4.75.1/orbit/pkg/setup_experience/setup_experience.go) and adding them back as `RunLegacy` and `startSwiftDialogLegacy`, then adding the little bit of plumbing to have `Run()` call `RunLegacy()` when the new capability is not detected. # Checklist for submitter If some of the following don't apply, delete the relevant line. ## Testing - [ ] Added/updated automated tests - [ ] Where appropriate, [automated tests simulate multiple hosts and test for host isolation](https://github.com/fleetdm/fleet/blob/main/docs/Contributing/reference/patterns-backend.md#unit-testing) (updates to one hosts's records do not affect another) - [X] QA'd all new/changed functionality manually Tested on a VM that the setup experience starts in "legacy" mode if `CapabilityMacOSWebSetupExperience` is not set in the server, and that it starts in the new web view if the capability _is_ set. For unreleased bug fixes in a release candidate, one of: - [X] Confirmed that the fix is not expected to adversely impact load test results - [ ] Alerted the release DRI if additional load testing is needed ## fleetd/orbit/Fleet Desktop - [X] Verified compatibility with the latest released version of Fleet (see [Must rule](https://github.com/fleetdm/fleet/blob/main/docs/Contributing/workflows/fleetd-development-and-release-strategy.md)) - [X] If the change applies to only one platform, confirmed that `runtime.GOOS` is used as needed to isolate changes - [ ] Verified that fleetd runs on macOS, Linux and Windows I have not re-verified this, but the changes will only run on macOS - [ ] Verified auto-update works from the released version of component to the new version (see [tools/tuf/test](../tools/tuf/test/README.md)) This should not be affected. |
||
|---|---|---|
| .. | ||
| setup_experience.go | ||
| setup_experience_test.go | ||