mirror of
https://github.com/fleetdm/fleet
synced 2026-05-19 15:09:20 +00:00
3757aace08
#8129 Apart from fixing the issue in #8129, this change also introduces UUIDs to Fleet errors. To be able to match a returned error from the API to a error in the Fleet logs. See https://fleetdm.slack.com/archives/C019WG4GH0A/p1677780622769939 for more context. Samples with the changes in this PR: ``` curl -k -H "Authorization: Bearer $TEST_TOKEN" -H 'Content-Type:application/json' "https://localhost:8080/api/v1/fleet/sso" -d '' { "message": "Bad request", "errors": [ { "name": "base", "reason": "Expected JSON Body" } ], "uuid": "a01f6e10-354c-4ff0-b96e-1f64adb500b0" } ``` ``` curl -k -H "Authorization: Bearer $TEST_TOKEN" -H 'Content-Type:application/json' "https://localhost:8080/api/v1/fleet/sso" -d 'asd' { "message": "Bad request", "errors": [ { "name": "base", "reason": "json decoder error" } ], "uuid": "5f716a64-7550-464b-a1dd-e6a505a9f89d" } ``` ``` curl -k -X GET -H "Authorization: Bearer badtoken" "https://localhost:8080/api/latest/fleet/teams" { "message": "Authentication required", "errors": [ { "name": "base", "reason": "Authentication required" } ], "uuid": "efe45bc0-f956-4bf9-ba4f-aa9020a9aaaf" } ``` ``` curl -k -X PATCH -H "Authorization: Bearer $TEST_TOKEN" "https://localhost:8080/api/latest/fleet/users/14" -d '{"name": "Manuel2", "password": "what", "new_password": "p4ssw0rd.12345"}' { "message": "Authorization header required", "errors": [ { "name": "base", "reason": "Authorization header required" } ], "uuid": "57f78cd0-4559-464f-9df7-36c9ef7c89b3" } ``` ``` curl -k -X PATCH -H "Authorization: Bearer $TEST_TOKEN" "https://localhost:8080/api/latest/fleet/users/14" -d '{"name": "Manuel2", "password": "what", "new_password": "p4ssw0rd.12345"}' { "message": "Permission Denied", "uuid": "7f0220ad-6de7-4faf-8b6c-8d7ff9d2ca06" } ``` - [X] Changes file added for user-visible changes in `changes/` or `orbit/changes/`. See [Changes files](https://fleetdm.com/docs/contributing/committing-changes#changes-files) for more information. - [X] Documented any API changes (docs/Using-Fleet/REST-API.md or docs/Contributing/API-for-contributors.md) - ~[ ] Documented any permissions changes~ - ~[ ] Input data is properly validated, `SELECT *` is avoided, SQL injection is prevented (using placeholders for values in statements)~ - ~[ ] Added support on fleet's osquery simulator `cmd/osquery-perf` for new osquery data ingestion features.~ - [X] Added/updated tests - [X] Manual QA for all new/changed functionality - For Orbit and Fleet Desktop changes: - [X] Manual QA must be performed in the three main OSs, macOS, Windows and Linux. - ~[ ] Auto-update manual QA, from released version of component to new version (see [tools/tuf/test](../tools/tuf/test/README.md)).~ |
||
|---|---|---|
| .. | ||
| .keep | ||
| 8129-fleet-errors-uuid-and-internal | ||
| 8186-fix-bug-with-docker-false-positive | ||
| 8411-jit-provisioning-roles | ||
| 9106-critical-icon-policy-table | ||
| 9415-aggregate-mac-settings-indicators | ||
| 9921-cis-win-10-2.3.10.x | ||
| 9924-cis-win-10-2.3.17.x | ||
| 10104-policy-tab-click-bug | ||
| 10137-show-query-policy-results | ||
| 10138-cis-win10-9-3-x | ||
| 10147-cis-win-10-18.x.x | ||
| 10228-okta-config-values | ||
| 10271-dep-okta | ||
| 10378-remove-attach-check | ||
| bugfix-mdm-settings-documentation | ||
| bugfix-trigger-release-lock | ||
| issue-9124-orbit-enroll-match-by-serial | ||
| issue-9400-add-disk-encryption-fleetctl-apply | ||
| issue-9433-support-modify-team-disk-encryption | ||
| issue-9435-disk-encryption-activities | ||
| issue-9437-add-host-disk-encryption-status | ||
| issue-9591-mdm-profiles-summary | ||
| issue-9596-mdm-profile-filter | ||
| issue-10126-mdm-info | ||
| issue-10136-cis-win-10-9-2-x | ||
| pin-dockerfiles | ||